Tx data refactor3 #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed some const ness issues to remove C++ warnings. Fixing typos and add missing comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to introduce improved SCREEN macros.
Our current screen showing code contains _getItem and _getNumItems that depend on each other quite a lot.
In previous PR's i introduced SCREEN macro and an approach to merge these two function into one _internal function.
However, this was a bit hacky and not general.
Here I try to generalize the approach so that it can be used on all screens, while making it more straightforward. It is stil a bit complex, due to the fact, that _internal function implements two interfaces at once, but I believe now, besides this, it is all very natural.