Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

djlinted templates #558

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

djlinted templates #558

wants to merge 1 commit into from

Conversation

KatiRG
Copy link
Collaborator

@KatiRG KatiRG commented Apr 26, 2024

What this PR accomplishes

Automatic fixes to lint errors by running djlint ckanext/ontario_theme/templates/ --reformat

What needs review

No special review necessary, these changes are only in format.

@KatiRG KatiRG requested a review from aleeexgreeen April 26, 2024 20:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert this change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since djlint removed the space, it would be best if we add an non-breaking space before {{ _('datasets') }}

Comment on lines +5 to 9
{% endblock subtitle %}


<div class="ontario-columns">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the addition spaces around the div, one space after the endblock should suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants