[Story]: Add checkboxes to the items in the search filters

[aleeexgreeen]

What this PR accomplishes

• Separates access level from filter sidebar and adds it to the search bar
• Defaults to open upon opening the dataset search page or an individual group / ministry page
• Defaults to open when all checkboxes are unchecked
• Reduce templates rendered on the dataset page (improving marginally the performance of page)
• Use of "search term" instead of "keyword(s)" and the use of "total"
• Clear filters button and filter facets now submit form instead of redirecting to links with filters as params in URL
• Search reset "x" now works when typing in a empty search box
• Adds text to empty search with additional datasets are present in different access levels
• Removes duplicate forms wrapping the search_form.html
• Adds callout with search term (if present) and access level(s) selected
• Adds an escape to the query string for search results

Issue(s) addressed

• DATA-1083, DATA-1272, DATA-1514

What needs review

• All filters should allow multiple checkboxes to be selected and operate as OR.
• Relationship between filters should operate as AND
• Callout is updated with every checkbox selected. When all checkboxes are selected "All levels" is displayed
• Callout is updated when there is no results. Callout is updated when there is a search term present
• The Access level filter should contain 3 items: Open, Under review and restricted. In this order
  Filters sidebar:
• All selected checkboxes should be visible, including when there are more than 5 items (will not be bumping it to the top of list)
• If there are more than 5 items selected than the default view be extended to more than 5 to include all selected items.
  Access level Zero results:
• if there are zero results in a search with all 3 checkboxes selected Display message “Please try another search or reach out to us if you think data is missing.“
• if there are zero results in a search for the selected checkbox(es) and there are datasets available in unselected checkboxes, there should be a message with a link to the search results of the access level with datasets displayed in the body of the page
  Other things needing review:
• Translations are present and correct
• implementation matches Figma design (to the best of my ability, Figma screens are not consistent)
• The number of datasets on homepage equals total dataset amount and not open dataset amount
• The number of datasets per on each Ministry on the ministry page is the total dataset amount and not open dataset amount
• Navigating the website, there are no internal server errors
• Clicking the search reset "x" when typing in a empty search box, resets the search box to empty

Tests should be done on individual ministry and group pages and the dataset search page

[KatiRG]

Can you djlint the html files?

[KatiRG]

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets":

Steps to reproduce:

1. select Restricted then deselect Open
2. select Topic aggregates (1)
3. select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

[aleeexgreeen]

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets":

Steps to reproduce:

1. select Restricted then deselect Open
2. select Topic aggregates (1)
3. select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

Hi @KatiRG, I don't have the environment or access set up at the moment, but can you revert the change proposed in #598 (comment) and let me know if this is still an issue?

[KatiRG]

@aleeexgreeen I found the following case where 1 dataset exists at level Restricted but when the Restricted access level is selected with the Open checkbox selected as well (also when all checkboxes are selected), that dataset is not shown and the callout says "No datasets":
Steps to reproduce:

1. select Restricted then deselect Open
2. select Topic aggregates (1)
3. select Open checkbox (and can also select Under Review checkbox so that all checkboxes are selected)

Hi @KatiRG, I don't have the environment or access set up at the moment, but can you revert the change proposed in #598 (comment) and let me know if this is still an issue?

Thanks @aleeexgreeen ! This solves the problem. I didn't notice the brackets around the second or grouping! I'll revert

[KatiRG]

fq_list is set here to [] but is never used again outside this if statement

[aleeexgreeen]

This is because the fq_list is used with setdefault(). The default value for fq_list is being set and modified within the if statement, so there is no need to use it outside the if statement, because it is being updated directly into search_params

[KatiRG]

There are indentation irregularities in this file that are not caught by djlint for some reason. e.g. in block {% block search_facets %} and onwards.

[aleeexgreeen]

You may have a different version of djlint or what you are using is not specifically tailored for this repo. There are files which the command pre-commit run --hook-stage manual format works from (see .djlintrc and djlint_rules.yaml). I say this because when running pre-commit run --hook-stage manual format there are no formatting errors in the search_form.html

[KatiRG]

In organization/read.html, you pass single_option_facet="organization" to facet_arrangement.html:

{{ h.snippet('snippets/facet_arrangement.html', extras={'id':c.group_dict.id}, 
single_option_facet="organization") }}

I'm wondering if you need to do the same for groups. Otherwise, all the groups will be listed in the facet column of an individual group page.

(screenshot from local)

[aleeexgreeen]

A dataset can only have one organization but a dataset can have multiple groups. On the groups page, does it make sense to show what other groups the datasets may be connected to?

[KatiRG]

Chrome screen reader is not reading this text. Can you confirm? And what are the options that are supposed to be read out?

[KatiRG]

Chrome screen reader is not reading this text after a topic is selected. Can you confirm?

[KatiRG]

Make it >= 3 since there is always the access_level element in the c.fields array that will count as 1, e.g.:

[aleeexgreeen]

This doesn't solve the problem, as you can have multiple access levels checked and c.fields|length will increase. All 3 access levels checked will have the same effect (The displaying of the button is all done in the javascript). I've opted to removing the if statement and leaving the javascript as if.