Develop -> Alpha #11
Open
Develop -> Alpha #11
+238
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This MR brings the `alpha` branch back into `develop`. It includes: - Updates to the CI/CD workflow to enable npm package publishing.
This fix handles validating numbers are numbers and not numbers are `NaN`.
- Add `undefined` and `null` checks to `isNumber` to guarentee they're
false.
- Add unit tests to validate this case via the `date-validation-utils` function `isInvalidYear`.
- Add unit tests to validate the `isNumber` util function.
Jira: DS-2103
Updates to `isNumeric` invalided the logic this function was using, inverting it restores intended functionality. - Add unit tests to validate different types of enum cases as well as `null` and `undefined`.
This fix handles validating numbers are numbers and not numbers are NaN. - Add unit tests to valid this case via the `date-validation-utils function` `isInvalidYear`. Closes DS-2103
This avoids build errors in some bundlers, eg. with NextJS.
This avoids build errors in some bundlers, eg. with NextJS. These changes have been tested by Dragan in his application and they compiled successfully. Closes DS-2067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the latest
developbranch toalpha. It includes a number of fixes and unit tests.Fixes
Utils (#8)
retrieveEnumKeysfunctiongrid.mixins(#10)