Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zero indexed keys on RangeAggregation #316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Syntaf
Copy link

@Syntaf Syntaf commented Mar 19, 2020

Allow '0' as a valid key for RangeAggregation objects

@Syntaf
Copy link
Author

Syntaf commented Mar 26, 2020

@saimaz 👋 do you have a moment to take a look at this bugfix? Thanks!

lsnider pushed a commit to gozowy/elasticsearch-dsl that referenced this pull request Aug 27, 2021
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (b4c3c89) to head (4bc0fa1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #316   +/-   ##
=========================================
  Coverage     78.67%   78.67%           
  Complexity      736      736           
=========================================
  Files           123      123           
  Lines          1899     1899           
=========================================
  Hits           1494     1494           
  Misses          405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants