feat(other): add oni2 command to PATH - Linux #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrossR
commented
Jan 14, 2020
| imgPath = path.join(appDirectory, "..", "Onivim2.icns") | ||
| } | ||
|
|
||
| const options = { name: "Oni2", icns: imgPath } |
There was a problem hiding this comment.
Need to check this (the icon)...its not showing up in my VM, but that could just be the weird flavour of Ubuntu I'm running...should try in regular ol Ubuntu or something like CentOS or Arch.
There was a problem hiding this comment.
Looks like this doesn't matter, since I can't get an icon to show up on Ubuntu at all (I can't see anywhere one would go). Its set correctly for the valid locations at least.
There was a problem hiding this comment.
I don't know what you're doing and I could be completely off, but .icns isn't a supported format in Desktop Entries, so maybe that also applies here.
glennsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work for the two Linux builds now, just want to give it a check with some pre-made builds and also check there is no regression on mac.
EDIT: Tested on mac and there is no regression. Just need to check the image issue.