Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(formatting/#785): Default format provider when no extension provider #2022

Merged
merged 9 commits into from
Jun 30, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jun 26, 2020

This completes the formatting work for #785 to hook up the = expression to format.

Currently, we rely on a range formatter and/or a document formatter to be available in order to process formats. This adds a basic default strategy, using the language configuration (increaseIndentExpression / decreaseIndentExpression) to apply formatting edits, if there is no extension available.

Fixes #785

Todo:

  • Get correct language configuration for buffer
  • Hook up format logic
  • Hook up range evaluations

@bryphe bryphe added the WIP label Jun 26, 2020
@bryphe bryphe removed the WIP label Jun 27, 2020
@bryphe bryphe merged commit 59c3513 into master Jun 30, 2020
@bryphe bryphe deleted the feat/formatting/785/default-formatter branch June 30, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: = deletes instead of reformatting
1 participant