fix(osx/#2924): Modifier keys not working with Romanji keyboard #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: On OSX, if the Romanji keyboard is selected, keys with modifiers (
Cmd+P, etc) would not be processed correctly.Defect: This was a regression from #2902 - in that change, we rely on querying our
keyboard-layoutlibrary for keymap information. However, we weren't able to get keymap information for Japanese / virtual keyboard layouts.Fix: Turns out a similar issue was encountered in the
node-native-keymaplibrary here: microsoft/node-native-keymap@f735d67Ported over a similar fix for our
keyboard-layoutstrategy - first, tryTISCopyCurrentKeyboardInputSource, and if that returnsNULL, tryTISCopyCurrentKeyboardLayoutInputSource.Fixes #2924