Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vim/#1633): Visual-block I and A implementation #3011

Merged
merged 12 commits into from
Jan 19, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 19, 2021

Issue: I and A in visual-block mode should allow inserting, or appending, characters across all linewise selections in the visual block

Fix: Implement using our in-progress multi-cursor support:

2021-01-19 12 02 59

Functionally, this should behave the same as <c-v>+I/A, but show all insertions during the gesture (as opposed to Vim, which would only show a single insertion, and then propagate them on the <esc> press).

A baby step towards snippets & multiple cursors

Fixes #1633
Related #1551

@bryphe bryphe added the WIP label Jan 19, 2021
@bryphe bryphe added N-screenshot Notes: Screenshot and removed WIP labels Jan 19, 2021
@bryphe bryphe added this to the 0.5.4 milestone Jan 19, 2021
@bryphe bryphe merged commit 9f92267 into master Jan 19, 2021
@bryphe bryphe deleted the fix/vim/1633/insert-visual-block branch January 19, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
N-screenshot Notes: Screenshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot insert at the start of lines with visual block
1 participant