turn halfspacetree to float generic #45
AdilZouitineAnnotations
18 warnings
|
using `clone` on type `F` which implements the `Copy` trait:
src/metrics/confusion.rs#L150
warning: using `clone` on type `F` which implements the `Copy` trait
--> src/metrics/confusion.rs:150:9
|
150 | / self.data
151 | | .get(label)
152 | | .unwrap_or(&HashMap::new())
153 | | .get(label)
154 | | .unwrap_or(&F::zero())
155 | | .clone()
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
help: try dereferencing it
|
150 ~ *self.data
151 + .get(label)
152 + .unwrap_or(&HashMap::new())
153 + .get(label)
154 + .unwrap_or(&F::zero())
|
|
|
using `clone` on type `F` which implements the `Copy` trait:
src/metrics/confusion.rs#L146
warning: using `clone` on type `F` which implements the `Copy` trait
--> src/metrics/confusion.rs:146:9
|
146 | self.sum_col.get(label).unwrap_or(&F::zero()).clone()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.sum_col.get(label).unwrap_or(&F::zero())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/metrics/accuracy.rs#L60
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/metrics/accuracy.rs:60:52
|
60 | .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
| ^^^^ help: change this to: `b.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/metrics/accuracy.rs#L37
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/metrics/accuracy.rs:37:52
|
37 | .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
| ^^^^ help: change this to: `b.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/common.rs#L218
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/common.rs:218:52
|
218 | .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
| ^^^^ help: change this to: `b.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`:
src/common.rs#L77
warning: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`
--> src/common.rs:77:5
|
77 | / pub fn from_iter<I: IntoClassifierTargetIter>(iter: I) -> Box<dyn Iterator<Item = Self>> {
78 | | iter.into_classifier_target_iter()
79 | | }
| |_____^
|
= help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
= note: `#[warn(clippy::should_implement_trait)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/anomaly/half_space_tree.rs#L124
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/anomaly/half_space_tree.rs:124:17
|
124 | &self.features.as_ref().unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.features.as_ref().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
unneeded `return` statement:
src/anomaly/half_space_tree.rs#L197
warning: unneeded `return` statement
--> src/anomaly/half_space_tree.rs:197:9
|
197 | return None;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
197 - return None;
197 + None
|
|
|
manual implementation of `Option::map`:
src/anomaly/half_space_tree.rs#L93
warning: manual implementation of `Option::map`
--> src/anomaly/half_space_tree.rs:93:21
|
93 | let trees = if let Some(features) = features {
| _____________________^
94 | | Some(Trees::new(n_trees, height, &features, &mut rng))
95 | | } else {
96 | | None
97 | | };
| |_________^ help: try this: `features.map(|features| Trees::new(n_trees, height, &features, &mut rng))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
|
associated function `new` is never used:
src/metrics/accuracy.rs#L12
warning: associated function `new` is never used
--> src/metrics/accuracy.rs:12:12
|
11 | impl<F: Float + FromPrimitive + AddAssign + SubAssign + MulAssign + DivAssign> Accuracy<F> {
| ------------------------------------------------------------------------------------------ associated function in this implementation
12 | pub fn new() -> Self {
| ^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L107
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:107:13
|
107 | trees: trees,
| ^^^^^^^^^^^^ help: replace it with: `trees`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L106
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:106:13
|
106 | n_nodes: n_nodes,
| ^^^^^^^^^^^^^^^^ help: replace it with: `n_nodes`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L105
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:105:13
|
105 | n_branches: n_branches,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_branches`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L104
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:104:13
|
104 | rng: rng,
| ^^^^^^^^ help: replace it with: `rng`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L102
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:102:13
|
102 | height: height,
| ^^^^^^^^^^^^^^ help: replace it with: `height`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L101
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:101:13
|
101 | n_trees: n_trees,
| ^^^^^^^^^^^^^^^^ help: replace it with: `n_trees`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
src/anomaly/half_space_tree.rs#L99
warning: redundant field names in struct initialization
--> src/anomaly/half_space_tree.rs:99:13
|
99 | window_size: window_size,
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|