Skip to content
Clippy check

Benchmark #34

Sign in to view logs

Benchmark

Benchmark #34

GitHub Actions / clippy failed Oct 5, 2023 in 0s

clippy

1 error, 7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 7
Note 0
Help 0

Versions

  • rustc 1.72.1 (d5c2e9c34 2023-09-13)
  • cargo 1.72.1 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (d5c2e9c 2023-09-13)

Annotations

Check warning on line 28 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

name `HST` contains a capitalized acronym 

warning: name `HST` contains a capitalized acronym
  --> src/main.rs:28:8
   |
28 | struct HST {
   |        ^^^ help: consider making the acronym lowercase, except the initial letter: `Hst`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
   = note: `#[warn(clippy::upper_case_acronyms)]` on by default

Check failure on line 5 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless lint attribute 

error: useless lint attribute
 --> src/main.rs:5:1
  |
5 | #[allow(dead_code)]
  | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
  = note: `#[deny(clippy::useless_attribute)]` on by default

Check warning on line 155 in src/metrics/confusion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `F` which implements the `Copy` trait 

warning: using `clone` on type `F` which implements the `Copy` trait
   --> src/metrics/confusion.rs:150:9
    |
150 | /         self.data
151 | |             .get(label)
152 | |             .unwrap_or(&HashMap::new())
153 | |             .get(label)
154 | |             .unwrap_or(&F::zero())
155 | |             .clone()
    | |____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
help: try dereferencing it
    |
150 ~         *self.data
151 +             .get(label)
152 +             .unwrap_or(&HashMap::new())
153 +             .get(label)
154 +             .unwrap_or(&F::zero())
    |

Check warning on line 146 in src/metrics/confusion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `F` which implements the `Copy` trait 

warning: using `clone` on type `F` which implements the `Copy` trait
   --> src/metrics/confusion.rs:146:9
    |
146 |         self.sum_col.get(label).unwrap_or(&F::zero()).clone()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.sum_col.get(label).unwrap_or(&F::zero())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 60 in src/metrics/accuracy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/metrics/accuracy.rs:60:52
   |
60 |                     .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
   |                                                    ^^^^ help: change this to: `b.1`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 37 in src/metrics/accuracy.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/metrics/accuracy.rs:37:52
   |
37 |                     .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
   |                                                    ^^^^ help: change this to: `b.1`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 218 in src/common.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/common.rs:218:52
    |
218 |                     .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
    |                                                    ^^^^ help: change this to: `b.1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 79 in src/common.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter` 

warning: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`
  --> src/common.rs:77:5
   |
77 | /     pub fn from_iter<I: IntoClassifierTargetIter>(iter: I) -> Box<dyn Iterator<Item = Self>> {
78 | |         iter.into_classifier_target_iter()
79 | |     }
   | |_____^
   |
   = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
   = note: `#[warn(clippy::should_implement_trait)]` on by default
View more details on GitHub Actions