Skip to content

Merge pull request #9 from MarcoDiFrancesco/main #55

Merge pull request #9 from MarcoDiFrancesco/main

Merge pull request #9 from MarcoDiFrancesco/main #55

GitHub Actions / clippy failed Apr 5, 2024 in 0s

clippy

1 error, 20 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 1
Warning 20
Note 0
Help 0

Versions

  • rustc 1.77.1 (7cf61ebde 2024-03-27)
  • cargo 1.77.1 (e52e36006 2024-03-26)
  • clippy 0.1.77 (7cf61eb 2024-03-27)

Annotations

Check failure on line 80 in src/stream/data_stream.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `stream::data_stream::Data<F>` implements inherent method `to_string(&self) -> String` which shadows the implementation of `Display`

error: type `stream::data_stream::Data<F>` implements inherent method `to_string(&self) -> String` which shadows the implementation of `Display`
  --> src/stream/data_stream.rs:73:5
   |
73 | /     pub fn to_string(&self) -> String {
74 | |         match self {
75 | |             Data::Scalar(v) => v.to_string(),
76 | |             Data::Int(v) => v.to_string(),
...  |
79 | |         }
80 | |     }
   | |_____^
   |
   = help: remove the inherent method from type `stream::data_stream::Data<F>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string_shadow_display
   = note: `#[deny(clippy::inherent_to_string_shadow_display)]` on by default

Check warning on line 155 in src/metrics/confusion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `F` which implements the `Copy` trait

warning: using `clone` on type `F` which implements the `Copy` trait
   --> src/metrics/confusion.rs:150:9
    |
150 | /         self.data
151 | |             .get(label)
152 | |             .unwrap_or(&HashMap::new())
153 | |             .get(label)
154 | |             .unwrap_or(&F::zero())
155 | |             .clone()
    | |____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
help: try dereferencing it
    |
150 ~         *self.data
151 +             .get(label)
152 +             .unwrap_or(&HashMap::new())
153 +             .get(label)
154 +             .unwrap_or(&F::zero())
    |

Check warning on line 146 in src/metrics/confusion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `F` which implements the `Copy` trait

warning: using `clone` on type `F` which implements the `Copy` trait
   --> src/metrics/confusion.rs:146:9
    |
146 |         self.sum_col.get(label).unwrap_or(&F::zero()).clone()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.sum_col.get(label).unwrap_or(&F::zero())`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
    = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 108 in src/metrics/confusion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value

warning: use of `or_insert_with` to construct default value
   --> src/metrics/confusion.rs:108:14
    |
108 |             .or_insert_with(HashMap::new)
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 218 in src/common.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/common.rs:218:52
    |
218 |                     .max_by(|a, b| a.1.partial_cmp(&b.1).unwrap())
    |                                                    ^^^^ help: change this to: `b.1`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 79 in src/common.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`

warning: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`
  --> src/common.rs:77:5
   |
77 | /     pub fn from_iter<I: IntoClassifierTargetIter>(iter: I) -> Box<dyn Iterator<Item = Self>> {
78 | |         iter.into_classifier_target_iter()
79 | |     }
   | |_____^
   |
   = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
   = note: `#[warn(clippy::should_implement_trait)]` on by default

Check warning on line 148 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/anomaly/half_space_tree.rs:148:17
    |
148 |                 &self.features.as_ref().unwrap(),
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.features.as_ref().unwrap()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 229 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> src/anomaly/half_space_tree.rs:229:9
    |
229 |         return None;
    |         ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
229 -         return None;
229 +         None
    |

Check warning on line 120 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `Option::map`

warning: manual implementation of `Option::map`
   --> src/anomaly/half_space_tree.rs:116:21
    |
116 |           let trees = if let Some(features) = features {
    |  _____________________^
117 | |             Some(Trees::new(n_trees, height, &features, &mut rng))
118 | |         } else {
119 | |             None
120 | |         };
    | |_________^ help: try: `features.map(|features| Trees::new(n_trees, height, &features, &mut rng))`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
    = note: `#[warn(clippy::manual_map)]` on by default

Check warning on line 89 in src/metrics/rocauc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
  --> src/metrics/rocauc.rs:89:13
   |
89 |             cms: cms,
   |             ^^^^^^^^ help: replace it with: `cms`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 88 in src/metrics/rocauc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
  --> src/metrics/rocauc.rs:88:13
   |
88 |             thresholds: thresholds,
   |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thresholds`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 87 in src/metrics/rocauc.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
  --> src/metrics/rocauc.rs:87:13
   |
87 |             pos_val: pos_val,
   |             ^^^^^^^^^^^^^^^^ help: replace it with: `pos_val`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 279 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `super::*`

warning: unused import: `super::*`
   --> src/anomaly/half_space_tree.rs:279:9
    |
279 |     use super::*;
    |         ^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

Check warning on line 132 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:132:13
    |
132 |             pos_val: pos_val,
    |             ^^^^^^^^^^^^^^^^ help: replace it with: `pos_val`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 130 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:130:13
    |
130 |             trees: trees,
    |             ^^^^^^^^^^^^ help: replace it with: `trees`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 129 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:129:13
    |
129 |             n_nodes: n_nodes,
    |             ^^^^^^^^^^^^^^^^ help: replace it with: `n_nodes`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 128 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:128:13
    |
128 |             n_branches: n_branches,
    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n_branches`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 127 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:127:13
    |
127 |             rng: rng,
    |             ^^^^^^^^ help: replace it with: `rng`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 125 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:125:13
    |
125 |             height: height,
    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 124 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:124:13
    |
124 |             n_trees: n_trees,
    |             ^^^^^^^^^^^^^^^^ help: replace it with: `n_trees`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

Check warning on line 122 in src/anomaly/half_space_tree.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/anomaly/half_space_tree.rs:122:13
    |
122 |             window_size: window_size,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window_size`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `#[warn(clippy::redundant_field_names)]` on by default