fix(user): calculate ranking (#367)

onlydustxyz · Oct 10, 2024 · 3532b90 · 3532b90
1 parent 607cb29
commit 3532b90
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/core/domain/application/models/application-list-item-model.ts b/core/domain/application/models/application-list-item-model.ts
@@ -29,7 +29,7 @@ export class ApplicationListItem implements ApplicationListItemInterface {
   getRank(): string {
     const position = this.applicant?.globalRank;
 
-    if (position === undefined) {
+    if (typeof position !== "number") {
       return "";
     }
 

diff --git a/core/domain/user/models/user-public-model.ts b/core/domain/user/models/user-public-model.ts
@@ -36,7 +36,8 @@ export class UserPublic implements UserPublicInterface {
 
   getRank(): string {
     const position = this.statsSummary?.rank;
-    if (position === undefined) {
+
+    if (typeof position !== "number") {
       return "";
     }
     // Check the last two digits to handle special cases like 11th, 12th, 13th, etc.

diff --git a/shared/features/contributors/contributor-overview/profile-card/profile-card.tsx b/shared/features/contributors/contributor-overview/profile-card/profile-card.tsx
@@ -25,6 +25,8 @@ export function ProfileCard({ user, headerProps, footerContent }: ProfileCardPro
   }, [headerProps]);
 
   const showRankPercentile = !!user.statsSummary?.rankPercentile && user.statsSummary?.rankPercentile !== 100;
+  const userRank = user.getRank();
+
   return (
     <Paper border={"primary"} classNames={{ base: "flex flex-col gap-lg" }}>
       {renderHeader}
@@ -35,7 +37,8 @@ export function ProfileCard({ user, headerProps, footerContent }: ProfileCardPro
             {user.login}
           </Typo>
           <Typo as={"div"} size={"sm"} color={"tertiary"}>
-            {user.getTitle().wording} • {user.getRank()}
+            {user.getTitle().wording}
+            {userRank ? ` • ${userRank}` : null}
             {showRankPercentile ? (
               <>
                 {" • "}