Skip to content

Use versions from the pnpm workspace instead of forcing them to be locked to hardcoded version #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 43 commits into
base: master
Choose a base branch
from

Conversation

onnimonni
Copy link
Owner

After merging the #1 and changing away from lerna to turbo the repository didn't build anymore.

This happened because we were referencing different versions of the internal packages:

notion-x-example-full:build: Failed to compile.
notion-x-example-full:build:
notion-x-example-full:build: ./components/NotionPage.tsx:149:9
notion-x-example-full:build: Type error: Type 'import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").ExtendedRecordMap' is not assignable to type 'import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/maps").ExtendedRecordMap'.
notion-x-example-full:build:   Types of property 'collection' are incompatible.
notion-x-example-full:build:     Type 'import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").CollectionMap' is not assignable to type 'import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/maps").CollectionMap'.
notion-x-example-full:build:       'string' index signatures are incompatible.
notion-x-example-full:build:         Type '{ role: import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").Role; value: import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").Collection; }' is not assignable to type '{ role: import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/core").Role; value: import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/collection").Collection; }'.
notion-x-example-full:build:           The types of 'value.schema' are incompatible between these types.
notion-x-example-full:build:             Type 'import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").CollectionPropertySchemaMap' is not assignable to type 'import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/collection").CollectionPropertySchemaMap'.
notion-x-example-full:build:               'string' index signatures are incompatible.
notion-x-example-full:build:                 Type 'import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").CollectionPropertySchema' is not assignable to type 'import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/collection").CollectionPropertySchema'.
notion-x-example-full:build:                   Types of property 'type' are incompatible.
notion-x-example-full:build:                     Type 'import("/Users/onnimonni/Projects/react-notion-x/packages/notion-types/build/index").PropertyType' is not assignable to type 'import("/Users/onnimonni/Projects/react-notion-x/node_modules/.pnpm/[email protected]/node_modules/notion-types/build/core").PropertyType'.
notion-x-example-full:build:                       Type '"status"' is not assignable to type 'PropertyType'.
notion-x-example-full:build:
notion-x-example-full:build:   147 |
notion-x-example-full:build:   148 |       <NotionRenderer
notion-x-example-full:build: > 149 |         recordMap={recordMap}
notion-x-example-full:build:       |         ^
notion-x-example-full:build:   150 |         fullPage={true}
notion-x-example-full:build:   151 |         darkMode={false}
notion-x-example-full:build:   152 |         rootDomain={rootDomain}
notion-x-example-full:build:  ELIFECYCLE  Command failed with exit code 1.
notion-x-example-full:build: ERROR: command finished with error: command (/Users/onnimonni/Projects/react-notion-x/examples/full) pnpm run build exited (1)

Let's change this by referring all internal packages to the monorepo version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants