Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not-working ort-nightly backend-test #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix not-working ort-nightly backend-test #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ffe3a
update dockerfile
andife Jul 26, 2023
7154cc4
update names
andife Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions DEV-INFO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Use these commands from the main directory of this repository to build Docker im
### Stable versions

* ONNX-Runtime: <br/>
`docker build -t scoreboard/onnx -f runtimes/onnx-runtime/stable/Dockerfile .`
`docker build -t scoreboard/ort -f runtimes/onnx-runtime/stable/Dockerfile .`

* ONNX-TF: <br/>
`docker build -t scoreboard/onnx-tf -f runtimes/onnx-tf/stable/Dockerfile .`
Expand All @@ -62,7 +62,7 @@ Use these commands from the main directory of this repository to build Docker im
### Development versions (built from source)

* ONNX-Runtime: <br/>
`docker build -t scoreboard/onnx -f runtimes/onnx-runtime/development/Dockerfile .`
`docker build -t scoreboard/ort-dev -f runtimes/onnx-runtime/development/Dockerfile .`

* ONNX-TF: <br/>
`docker build -t scoreboard/onnx-tf -f runtimes/onnx-tf/onnx-tf/Dockerfile .`
Expand All @@ -89,7 +89,7 @@ store results in the directory specified as `results_dir` in `config.json`.
### Stable

* ONNX-Runtime <br/>
`docker run --name onnx-runtime --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-runtime/stable:/root/results scoreboard/onnx`
`docker run --name ort --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-runtime/stable:/root/results scoreboard/ort`

* ONNX-TF <br/>
`docker run --name onnx-tf --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-tf/stable:/root/results scoreboard/onnx-tf`
Expand All @@ -100,7 +100,7 @@ store results in the directory specified as `results_dir` in `config.json`.
### Development (build from source)

* ONNX-Runtime <br/>
`docker run --name onnx-runtime --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-runtime/development:/root/results scoreboard/onnx`
`docker run --name ort-dev --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-runtime/development:/root/results scoreboard/ort-dev`

* ONNX-TF <br/>
`docker run --name onnx-tf --env-file setup/env.list -v ~/backend-scoreboard/results/onnx-tf/development:/root/results scoreboard/onnx-tf`
Expand Down
10 changes: 5 additions & 5 deletions runtimes/onnx-runtime/development/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ FROM ubuntu:20.04
ENV DEBIAN_FRONTEND=noninteractive

# Install Python and locales dependencies
RUN apt-get update && apt-get install -y \
RUN apt-get update && apt-get install -y --no-install-recommends \
python3 \
python3-dev \
python3-pip \
Expand All @@ -27,10 +27,10 @@ ENV ONNX_BACKEND="onnxruntime.backend.backend"
RUN locale-gen en_US.UTF-8 && update-locale LANG=en_US.UTF-8

# Install dependencies
RUN pip3 install onnx
RUN pip3 install ort-nightly
RUN pip3 install protobuf==3.20.2
RUN pip3 install numpy==1.22.4
# according to https://github.com/microsoft/onnxruntime/issues/15608
RUN pip3 install onnx protobuf==3.20.2 numpy==1.22.4 coloredlogs flatbuffers packaging sympy
RUN pip3 install ort-nightly --index-url https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT-Nightly/pypi/simple/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link be inaccessible? It says PublicPackages in it, but I'm getting The user <user> is not authorized to access when trying to go to that link. Otherwise, as long as it's being updated with latest nightly releases, LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with PublicPackages?

executing "pip3 install ort-nightly --index-url https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT-Nightly/pypi/simple" at the cli worked me

Copy link
Member Author

@andife andife May 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we now have results at http://onnx.ai/backend-scoreboard/index_dev.html I think its ready to merge... I'm only a bit surprised as onnx-weekly is not working, but ort-nightly from https://aiinfra.pkgs.visualstudio.com is used

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with PublicPackages?

Nevermind, it's okay.

I'm only a bit surprised as onnx-weekly is not working

It seems it's to be expected: onnx/onnx#5233. I also think this can be merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the packages from testpypi are removed. they are uploaed to pypi directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge? Who has the right's?



####################################################

Expand Down