Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for auto_detect_ep function #40

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix typo for auto_detect_ep function #40

merged 2 commits into from
Nov 18, 2024

Conversation

mengniwang95
Copy link
Contributor

Type of Change

bug fix

@mengniwang95
Copy link
Contributor Author

it seems the CI failure is due to latest torch can't export > 2GB model to ONNX model:
pytorch/pytorch#132205
huggingface/optimum#1800

@Crafter-san
Copy link

@hshen14 it's been 4 days since the provided changes were approved, please merge

@thuang6
Copy link
Contributor

thuang6 commented Nov 18, 2024

@hshen14 it's been 4 days since the provided changes were approved, please merge

@Crafter-san,since there is no available solution to fix export issue on latest Torch currently, we are trying to find out the proper Torch version, which will be limited in CI test. The PR will be merged soon after this walk around applied in CI

Signed-off-by: Wang, Mengni <[email protected]>
@mengniwang95
Copy link
Contributor Author

Unit Test ONNXRT baseline runs the unittest of main branch, its failure makes sense.
Unit Test ONNXRT runs the unittest of this PR's branch, it has passed.
So we can merge this PR

@thuang6 thuang6 merged commit 3dd43d3 into main Nov 18, 2024
11 of 13 checks passed
@Crafter-san
Copy link

Crafter-san commented Nov 18, 2024

@thuang6 here is the possible offender for the size limit, according to another user:
issue page: pytorch/pytorch#132205
commit page: pytorch/pytorch@163847b#diff-849a5778e2dcf7f36587967273cee0bf20642e35bf4c79405111ea3417c3fb3cR716

If you could share this with the rest of the team, you guys could possibly go through and fix the issue and make a pull request. I don't have enough Python experience to fix the issue myself.

@Crafter-san
Copy link

additionally, the issue is within it requiring a filename to properly write it to a file. I don't know how, but perhaps including an arg for filename, and a default filename (for people using things like Optimum CLI that don't have access to the direct args)

@Crafter-san
Copy link

Pytorch issue is in the process of being fixed: pytorch/pytorch#140962
It will soon merge and hopefully fix export issues

@Crafter-san
Copy link

Reversion complete
pytorch/pytorch#140961
pytorch/pytorch#140962
Please act accordingly

@mengniwang95
Copy link
Contributor Author

Reversion complete pytorch/pytorch#140961 pytorch/pytorch#140962 Please act accordingly

Hi, thank you for your reminder, we will remove the version control after torch latest version is released which contains this commit.

@Crafter-san
Copy link

@mengniwang95 when will it be fixed? There's no new versions/releases

@mengniwang95
Copy link
Contributor Author

Hi @Crafter-san , this fix is in pytorch source code and now what we need to do is waiting for the new release of pytorch to fix this issue. If you failed to export onnx model due to this issue, you can downgrade your pytorch version or build pytorch from its main branch source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants