Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice and Unsqueeze ops bug fixes in v5.0 #293

Open
wants to merge 1 commit into
base: v5.0
Choose a base branch
from

Conversation

jimmylomro
Copy link

Slice: Assertion is done without correcting for negative axes. Also, comparison in done in wrong indices (nbdims-1 and nbdims) with respect to actual HW dimensions (nbdims-2 and nbdims-1).

Unsqueeze: Not accounting for negative axes.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jaime Lomeli seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants