Vault/allow multiple currency #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Son/auction multiple stable
DongLieu
reviewed
Nov 5, 2024
auction: fix abci aution
Vaults: Add test vaults abci
vaults: Add beginblocker vaults
vaults: Add validate StabilityFee
vault: add default for DefaultMintDenoms
hieuvubk
reviewed
Nov 7, 2024
| string denom = 1; | ||
| string debt_denom = 1; | ||
|
|
||
| string mint_denom = 2; |
There was a problem hiding this comment.
we should rename. Lets say debt and mint denom is same nomUSD
| @@ -142,7 +144,9 @@ message VaultLiquidationStatus { | |||
| } | |||
|
|
|||
| message Liquidation { | |||
| string denom = 1; | |||
| string debt_denom = 1; | |||
There was a problem hiding this comment.
should be collateral_denom I think
| @@ -31,7 +34,8 @@ func (k Keeper) GetNewAuction(ctx context.Context, | |||
| if newAuction != nil { | |||
| return newAuction, false, nil | |||
| } | |||
| newAuction, err = k.NewAuction(ctx, startTime, initialPrice, item, targetGoal, vaultId) | |||
| newAuction, err = k.NewAuction(ctx, startTime, initialPrice, item, targetGoal, vaultId, vault.Debt.Denom) | |||
|
|
|||
| if err != nil { | |||
| return newAuction, true, err | |||
There was a problem hiding this comment.
if err != nil so the auction should not be created. Let check the bool return
| @@ -58,7 +63,7 @@ func (k Keeper) NewAuction(ctx context.Context, | |||
| LastDiscountTime: startTime, | |||
| Status: types.AuctionStatus_AUCTION_STATUS_ACTIVE, | |||
| TargetGoal: targetGoal, | |||
| TokenRaised: sdk.NewCoin(vaultstypes.DefaultMintDenom, math.ZeroInt()), | |||
| TokenRaised: sdk.NewCoin(mintDenom, math.ZeroInt()), | |||
| if price == nil || price.IsNil() { | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "CreateNewVault: can not get price with base %s quote %s", denom, types.DefaultMintDenom) | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "CreateNewVault: can not get price with base %s quote %s", denom, types.DefaultMintDenoms) |
There was a problem hiding this comment.
Suggested change
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "CreateNewVault: can not get price with base %s quote %s", denom, types.DefaultMintDenoms) | |
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "CreateNewVault: can not get price with base %s quote %s", denom, mint.Denom) |
| if price == nil || price.IsNil() { | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "MintCoin: can not get price with base %s quote %s", lockedCoin.Denom, types.DefaultMintDenom) | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "MintCoin: can not get price with base %s quote %s", lockedCoin.Denom, types.DefaultMintDenoms) |
| // defensive programming: should never happen since when withdraw should always have a valid oracle price | ||
| if price == nil || price.IsNil() { | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "WithdrawFromVault: can not get price with base %s quote %s", collateral.Denom, types.DefaultMintDenom) | ||
| return errors.Wrapf(oracletypes.ErrInvalidOracle, "WithdrawFromVault: can not get price with base %s quote %s", collateral.Denom, types.DefaultMintDenoms) |
| if price == nil || price.IsNil() { | ||
| return true, errors.Wrapf(oracletypes.ErrInvalidOracle, "GetLiquidations: can not get price with base %s quote %s", vm.Denom, types.DefaultMintDenom) | ||
| return true, errors.Wrapf(oracletypes.ErrInvalidOracle, "GetLiquidations: can not get price with base %s quote %s", vm.Denom, types.DefaultMintDenoms) |
vaults: check status
Psm: allow multiple currency for psm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #75