remove dependency on github.com/hpcloud/tail #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammed90
changed the title
mohammed90
changed the title
mohammed90
force-pushed
the
remove-dep-tail
branch
from
6253993
to
53fe7fd
Compare
mohammed90
force-pushed
the
remove-dep-tail
branch
from
53fe7fd
to
37c2426
Compare
mohammed90
force-pushed
the
remove-dep-tail
branch
from
e1522b9
to
7d237fd
Compare
|
Okay, I'm at loss now. The failures recur despite the code is almost exactly as it were, except for the streaming part and a few additional OS-specific files. Different Go versions have different results, though Go 1.12.x and Go tip have matching results. Those particular tests don't seem to be run for other PRs and master, which is odd given that the test suit doesn't seem to have changed lately (unless I'm mis-seeing). Successfully removing github.com/hpcloud/tail makes the this package usable on Dragonfly and Illumos. I've addressed the limitation for Plan9. Nacl is a different story. |
mohammed90
changed the title
|
I guess it isn't needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #622 and adds Windows support as positive side-effect