Filter name tags #1115
Merged
Filter name tags #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full logs: https://github.com/onthegomap/planetiler/actions/runs/12021905765 |
1ec5
reviewed
Nov 26, 2024
| @@ -10,7 +10,7 @@ public class LanguageUtils { | |||
| // See https://wiki.openstreetmap.org/wiki/Multilingual_names | |||
| public static final Predicate<String> VALID_NAME_TAGS = | |||
| Pattern | |||
| .compile("^name:[a-z]{2,3}(-[a-z]{4})?([-_](x-)?[a-z]{2,})?(-([a-z]{2}|[0-9]{3}))?$", Pattern.CASE_INSENSITIVE) | |||
| .compile("^name:[a-z]{2,3}(-[a-z]{4})?([-_](x-)?[a-z]{2,})?(-([a-z]{2}|\\d{3}))?$", Pattern.CASE_INSENSITIVE) | |||
There was a problem hiding this comment.
I just realized this pattern is case-insensitive. This means it’ll pull in both name:tec=* and name:TEC=* – the latter is not a localized name. The usual case conventions for IETF language tags apply (language codes as xyz, script codes as Wxyz, country codes as XY). Some miscased keys have been common in the past, but as far as I know, they’re now deprecated (see also osmus/tileservice#21).
| @@ -10,7 +10,7 @@ public class LanguageUtils { | |||
| // See https://wiki.openstreetmap.org/wiki/Multilingual_names | |||
| public static final Predicate<String> VALID_NAME_TAGS = | |||
| Pattern | |||
| .compile("^name:[a-z]{2,3}(-[a-z]{4})?([-_](x-)?[a-z]{2,})?(-([a-z]{2}|[0-9]{3}))?$", Pattern.CASE_INSENSITIVE) | |||
| .compile("^name:[a-z]{2,3}(-[a-z]{4})?([-_](x-)?[a-z]{2,})?(-([a-z]{2}|\\d{3}))?$", Pattern.CASE_INSENSITIVE) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1114 by filtering name tags that don't correspond to different languages.