Merge pull request #999 from ontodev/elk05

Updating ELK 0.43 to 0.5
ontodev · Sep 20, 2023 · 0e0c7da · 0e0c7da
2 parents 4c90dfc + 8e375d5
commit 0e0c7da
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- Updated ELK from 0.4.3 to 0.5.0. [#999]. This is an important change as ELK 0.5.0 is more complete than 0.4.3, which means that it will potentially uncover inferences, in particular unsatisfiable classes, which were not recognised by ELK 0.4.3.
+
 ## [1.9.4] - 2023-05-23
 
 ### Changed

diff --git a/pom.xml b/pom.xml
@@ -211,9 +211,9 @@
       <version>1.7.32</version>
     </dependency>
     <dependency>
-      <groupId>org.semanticweb.elk</groupId>
-      <artifactId>elk-owlapi</artifactId>
-      <version>0.4.3</version>
+      <groupId>au.csiro</groupId>
+      <artifactId>elk-owlapi4</artifactId>
+      <version>0.5.0</version>
       <exclusions>
         <exclusion>
           <groupId>log4j</groupId>

diff --git a/robot-core/src/main/java/org/obolibrary/robot/ReasonerHelper.java b/robot-core/src/main/java/org/obolibrary/robot/ReasonerHelper.java
@@ -46,9 +46,8 @@ public class ReasonerHelper {
   public static Set<OWLObjectProperty> getUnsatisfiableObjectProperties(OWLReasoner reasoner) {
     Set<OWLObjectProperty> unsatObjectProps = new HashSet<>();
 
-    if (reasoner
-        .getPrecomputableInferenceTypes()
-        .contains(InferenceType.OBJECT_PROPERTY_HIERARCHY)) {
+    if (reasoner.getPrecomputableInferenceTypes().contains(InferenceType.OBJECT_PROPERTY_HIERARCHY)
+        && !reasoner.getClass().getName().equals("org.semanticweb.elk.owlapi.ElkReasoner")) {
       // Fast object-unsat check
       logger.info(
           "Object-property precomputation is supported; using that to find unsatisfiable object properties...");