Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that robot query accepts multiple --query options #1233

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

allenbaron
Copy link
Contributor

@allenbaron allenbaron commented Dec 12, 2024

Requested in #1222.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

This adds a brief comment and example, built from combining the previous two examples, to the docs for the query command to clarify that it accepts multiple --query options in a single invocation.

I also confirmed that the example works by executing it in the docs/examples dir.

How does the query command handle the --format option in this scenario. Does that need to be included in the docs as well?

@jamesaoverton
Copy link
Member

Much appreciated!

QueryCommand iterates over the queries, handling each one separately with its own format: https://github.com/ontodev/robot/blob/master/robot-command/src/main/java/org/obolibrary/robot/QueryCommand.java#L399

The second paragraph says "The output format will be inferred from the output file extension, or you can use the --format option." so I think that's enough.

@jamesaoverton jamesaoverton merged commit ac92f26 into ontodev:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants