Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use subcondition of list in get_matching_values #102

Merged
merged 105 commits into from
Sep 4, 2024
Merged

Use subcondition of list in get_matching_values #102

merged 105 commits into from
Sep 4, 2024

Conversation

jamesaoverton
Copy link
Member

@jamesaoverton jamesaoverton commented Jul 26, 2024 •
edited by lmcmicu
Loading

Closes #109, closes #101, closes #89, closes #104, closes #105

@jamesaoverton jamesaoverton requested a review from lmcmicu July 26, 2024 14:30
@lmcmicu lmcmicu self-assigned this Jul 30, 2024
lmcmicu
lmcmicu reviewed Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@lmcmicu lmcmicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

lmcmicu added 14 commits August 1, 2024 10:07
@lmcmicu
remove foreign key cache
8ca60b2
@lmcmicu
first pass trial implementation of new caching method for validate_ro…
0b71b08 
…ws_constraints()
@lmcmicu
consider conflict tables when determining forbidden and allowed value…
30a1dda 
…s for cache
@lmcmicu
accept a list of 'received values' in when validating foreign and uni…
4eb7708 
…que constraints for a cell
@lmcmicu
check for sql type errors when collecting values for cache
159a5b6
@lmcmicu
clean up fkey_in_db()
6ec116b
@lmcmicu
take list values into account when collecting received_values for cac…
7df1ec0 
…hing
@lmcmicu
fetch allowed and forbidden values less often
84f4de1
@lmcmicu
add tree children to unique cache
4be55d5
@lmcmicu
use vertical caching in unique validation
e495616
@lmcmicu
tweak
a001df7
@lmcmicu
fix unique caching check
cbf21e4
@lmcmicu
increase perf_test rows and add it to workflow
7303d5d
@lmcmicu
tweaks
ebc7048
lmcmicu added 27 commits August 29, 2024 17:26
@lmcmicu
tweak
5e6266a
@lmcmicu
return an error if asked to save to a default non-tsv path; add commo…
a216451 
…n option combinations section to readme
@lmcmicu
allow 'save as' for non-saveable tables
87db022
@lmcmicu
start on validation section
eb780fb
@lmcmicu
try mermaid flow chart
dd72d9d
@lmcmicu
test mermaid diagram
a4d0b8c
@lmcmicu
add validation flowchart
749742e
@lmcmicu
tweak validation flowchart
2771fa1
@lmcmicu
tweak validation flowchart
3b12cae
@lmcmicu
tweak validation flowchart
36487ea
@lmcmicu
add headers for subsections to be done
c94ada2
@lmcmicu
add more validation stuff to readme
5ea7f91
@lmcmicu
add section on batch validation
878b759
@lmcmicu
fix typo
a42e491
@lmcmicu
add stuff to readme on editing data
282c4a1
@lmcmicu
complete first draft of design and concepts documentation
fa28ee2
@lmcmicu
add table of contents to readme
b1b67a6
@lmcmicu
use better example in readme
c82b253
@lmcmicu
tweak
cc1f04a
@lmcmicu
tweak
589e45c
@lmcmicu
table formatting
d25716c
@lmcmicu
table formatting
25416f3
@lmcmicu
table formatting
c040aa0
@lmcmicu
typo fixes
68ca403
@lmcmicu
typo fixes
4678042
@lmcmicu
small readme updates
21ea38f
@lmcmicu
fix typos and tweaks
a5c3e17
@lmcmicu lmcmicu marked this pull request as ready for review September 4, 2024 14:33
@lmcmicu lmcmicu merged commit 8aac6b0 into main Sep 4, 2024
2 checks passed
@lmcmicu lmcmicu deleted the use-list-subcondition branch September 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmcmicu lmcmicu lmcmicu left review comments

Assignees

@lmcmicu lmcmicu

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jamesaoverton @lmcmicu