Create new user-friendly view #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review as far as I'm concerned, but I am leaving the PR in draft mode since #59 must be merged first (see the description of this PR). |
|
This has been working for me so far. I would like two changes, please:
|
|
Done. I've changed |
…inserting new rows, even when there are errors.
…s they result in db errors
This is not necessary in most cases and makes the code confusing. There was a need, previously, because we used to call the update/insert/delete single row functions directly on the conflict table in some cases - the reason being that the update_row function had two possible paths, one direct and one indirect. Now that it is always indirect we can clean this up. The only time where it is still needed is when we are actually generating insert statements.
…tree-foreigns and under constraints
…rd_to_redo() and get_last_change() to get_record_to_undo()
lmcmicu
force-pushed
the
new-view-forked-from-undo-redo
branch
from
93aa011 to
8e17891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially closes #58 (if we decide on this solution). Note that this branch has been forked from the undo-redo branch (which is the reason why the diff shows changes other than the one in b4484ff (which adds the new view)).
Before merging this PR, PR #59 must be merged to main first and then this branch should be rebased onto main. I am leaving this PR in draft mode to prevent inadvertently merging it before this has been done.