Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.58.2 to 0.89.1 #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps rubocop from 0.58.2 to 0.89.1.

Release notes

Sourced from rubocop's releases.

RuboCop 0.89.1

Bug fixes

  • #8463: Fix false positives for Lint/OutOfRangeRegexpRef when a regexp is defined and matched in separate steps. (@eugeneius)
  • #8464: Handle regexps matched with when, grep, gsub, gsub!, sub, sub!, [], slice, slice!, scan, index, rindex, partition, rpartition, start_with?, and end_with? in Lint/OutOfRangeRegexpRef. (@eugeneius)
  • #8466: Fix a false positive for Lint/UriRegexp when using regexp method without receiver. (@koic)
  • #8478: Relax Lint/BinaryOperatorWithIdenticalOperands for mathematical operations. (@marcandre)
  • #8480: Tweak callback list of Lint/MissingSuper. (@marcandre)
  • #8481: Fix autocorrect for elements with newlines in Style/SymbolArray and Style/WordArray. (@biinari)
  • #8475: Fix a false positive for Style/HashAsLastArrayItem when there are duplicate hashes in the array. (@wcmonty)
  • #8497: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside a parenthesized method argument list. (@dsavochkin)

Changes

  • #8487: Detect < and > as comparison operators in Style/ConditionalAssignment cop. (@biinari)

RuboCop 0.89

New features

Bug fixes

  • #8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])
  • #8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])
  • #8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. (@biinari)
Changelog

Sourced from rubocop's changelog.

0.89.1 (2020-08-10)

Bug fixes

  • #8463: Fix false positives for Lint/OutOfRangeRegexpRef when a regexp is defined and matched in separate steps. ([@eugeneius][])
  • #8464: Handle regexps matched with when, grep, gsub, gsub!, sub, sub!, [], slice, slice!, scan, index, rindex, partition, rpartition, start_with?, and end_with? in Lint/OutOfRangeRegexpRef. ([@eugeneius][])
  • #8466: Fix a false positive for Lint/UriRegexp when using regexp method without receiver. ([@koic][])
  • #8478: Relax Lint/BinaryOperatorWithIdenticalOperands for mathematical operations. ([@marcandre][])
  • #8480: Tweak callback list of Lint/MissingSuper. ([@marcandre][])
  • #8481: Fix autocorrect for elements with newlines in Style/SymbolArray and Style/WordArray. ([@biinari][])
  • #8475: Fix a false positive for Style/HashAsLastArrayItem when there are duplicate hashes in the array. ([@wcmonty][])
  • #8497: Fix Style/IfUnlessModifier to add parentheses when converting if-end condition inside a parenthesized method argument list. ([@dsavochkin][])

Changes

  • #8487: Detect < and > as comparison operators in Style/ConditionalAssignment cop. ([@biinari][])

0.89.0 (2020-08-05)

New features

Bug fixes

  • #8346: Allow parentheses in single-line inheritance with Style/MethodCallWithArgsParentheses EnforcedStyle: omit_parentheses to fix invalid Ruby auto-correction. ([@gsamokovarov][])
  • #8324: Fix crash for Layout/SpaceAroundMethodCallOperator when using Proc#call shorthand syntax. ([@fatkodima][])
  • #8332: Fix auto-correct in Style/ConditionalAssignment to preserve constant namespace. ([@biinari][])
  • #8344: Fix crash for Style/CaseLikeIf when checking against equal? and match? without a receiver. ([@fatkodima][])
  • #8323: Fix a false positive for Style/HashAsLastArrayItem when hash is not a last array item. ([@fatkodima][])
  • #8299: Fix an incorrect auto-correct for Style/RedundantCondition when using raise, rescue, or and without argument parentheses in else. ([@koic][])
  • #8335: Fix incorrect character class detection for nested or POSIX bracket character classes in Style/RedundantRegexpEscape. ([@owst][])
  • #8347: Fix an incorrect auto-correct for EnforcedStyle: hash_rockets of Style/HashSyntax with Layout/HashAlignment. ([@koic][])
Commits
  • e27942a Cut 0.89.1
  • 3cba823 [Fix #8497] Fix Style/IfUnlessModifier to handle if-end condition in method a...
  • 78f1ec9 Alter multiline memoization message for braces enforced style
  • e0f28e0 Deprecate comment_lines?
  • 9a08fde Avoid use of ProcessedSource#commented?
  • 28eabb7 Fix Style/EmptyCaseCondition's autocorrect.
  • 14a5c20 Avoid comments_before_line
  • 8a02e42 Simplify and optimize comment lookup
  • a0ec799 New rubocop-ast insures that ProcessedSource#comments is never nil.
  • 7fd90a4 Avoid use of each_comment
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #623   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          399       399           
  Lines        10675     10675           
=========================================
  Hits         10675     10675           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adfe0b6...0b34ac6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant