add haml-lint to detect no localized stings in haml files

.github/workflows/rubocop.yml

@@ -1,15 +1,36 @@
-name: Code style
+name: Linters
 
-on: [ pull_request ]
+on: [push, pull_request]
 
 jobs:
-  lint:
-    name: all linters
+  rubocop:
+    name: RuboCop
     runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
-      - name: rubocop
-        run: bin/ontoportal run bundle exec rubocop --parallel
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0.0
+
+      - name: Install dependencies
+        run: gem install rubocop rubocop-rails rubocop-i18n
+
+
+      - name: Run RuboCop
+        run: rubocop  --parallel --format github
+
+  haml-lint:
+    name: HamlLint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install HamlLint
+        run: gem install  haml-lint
+
+      - name: Run HamlLint
+        run: haml-lint -r github

.haml-lint.yml

@@ -0,0 +1,137 @@
+require:
+  - './lib/lint/no_localized_string_haml.rb' 
+
+linters:
+  CustomLinter:
+    enabled: true
+    include: '**/*.haml'
+
+# Default application configuration that all configurations inherit from.
+#
+# This is an opinionated list of which hooks are valuable to run and what their
+# out of the box settings should be.
+
+# Whether to ignore frontmatter at the beginning of HAML documents for
+# frameworks such as Jekyll/Middleman
+skip_frontmatter: false
+
+linters:
+
+  MyFirstLinter: 
+    enabled: true
+
+  NoPlainTextLinter:
+    enabled: true
+
+  AlignmentTabs:
+    enabled: true
+
+  AltText:
+    enabled: false
+
+  ClassAttributeWithStaticValue:
+    enabled: true
+
+  ClassesBeforeIds:
+    enabled: true
+
+  ConsecutiveComments:
+    enabled: true
+    max_consecutive: 1
+
+  ConsecutiveSilentScripts:
+    enabled: true
+    max_consecutive: 2
+
+  EmptyObjectReference:
+    enabled: true
+
+  EmptyScript:
+    enabled: true
+
+  FinalNewline:
+    enabled: true
+    present: true
+
+  HtmlAttributes:
+    enabled: true
+
+  IdNames:
+    enabled: true
+    style: lisp_case
+
+  ImplicitDiv:
+    enabled: true
+
+  Indentation:
+    enabled: true
+    character: space # or tab
+    width: 2 # ignored if character == tab
+
+  InlineStyles:
+    enabled: true
+
+  InstanceVariables:
+    enabled: true
+    file_types: partials
+    matchers:
+      all: .*
+      partials: \A_.*\.haml\z
+
+  LeadingCommentSpace:
+    enabled: true
+
+  LineLength:
+    enabled: true
+    max: 80
+
+  MultilinePipe:
+    enabled: true
+
+  MultilineScript:
+    enabled: true
+
+  NoPlaceholders:
+    enabled: false
+
+  ObjectReferenceAttributes:
+    enabled: true
+
+  RepeatedId:
+    enabled: true
+    severity: error
+
+  RuboCop:
+    enabled: true
+    # Users can ignore cops using this configuration instead of editing their rubocop configuration.
+    # Mostly there for backward compatibility.
+    ignored_cops: []
+
+  RubyComments:
+    enabled: true
+
+  SpaceBeforeScript:
+    enabled: true
+
+  SpaceInsideHashAttributes:
+    enabled: true
+    style: space
+
+  TagName:
+    enabled: true
+
+  TrailingEmptyLines:
+    enabled: true
+
+  TrailingWhitespace:
+    enabled: true
+
+  UnnecessaryInterpolation:
+    enabled: true
+
+  UnnecessaryStringOutput:
+    enabled: true
+
+  ViewLength:
+    enabled: true
+    max: 100

.rubocop.yml

@@ -18,6 +18,7 @@ AllCops:
 require:
   - rubocop-rails
   - ./lib/lint/non_localized_string.rb
+  - rubocop-i18n
 Lint/NonLocalizedString:
   Enabled: true
 
@@ -76,3 +77,6 @@ Style/MissingRespondToMissing:
 Lint/MissingSuper:
   Enabled: true
 
+
+Rails/I18nLocaleTexts:
+  Enabled: true

Gemfile

@@ -119,6 +119,8 @@ group :development do
   gem 'deepl-rb'
   gem 'letter_opener_web', '~> 2.0'
   gem 'haml-rails'
+  gem "rubocop-i18n", "~> 3.0"
+  gem 'haml_lint', require: false
 end
 
 group :test, :development do
@@ -140,4 +142,4 @@ gem "net-http", "~> 0.3.2"
 
 
 
-gem "bugsnag", "~> 6.26"
+gem "bugsnag", "~> 6.26"