Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update footer design #234

Merged
merged 8 commits into from
May 8, 2023

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Apr 17, 2023

Problem

  • The existing footer has bad styling.
  • It needs some changes in its elements.
  • It doesn't support multilingualism.

Solution

  • I updated the design of the footer.
  • I edited some elements and added others.
  • I made the footer supports multilingualism.

$FOOTER_LINKS variable is in the comments below.

Screenshots

Before
image

After
Footer

@Bilelkihal Bilelkihal added the enhancement New feature or request label Apr 17, 2023
@Bilelkihal Bilelkihal self-assigned this Apr 17, 2023
@Bilelkihal

This comment was marked as outdated.

syphax-bouazzouni

This comment was marked as outdated.

…ted to internationalization must be done and centralized in the local's files (e.gen.ymland fr.yml)
@Bilelkihal

This comment was marked as outdated.

@haddadzineddine

This comment was marked as outdated.

@syphax-bouazzouni syphax-bouazzouni linked an issue May 8, 2023 that may be closed by this pull request
@syphax-bouazzouni
Copy link
Collaborator

Added

  • Add footer en translation local file(9b67684)
  • Refactor $FOOTER_LINKS loop to use key, value, and not only the keys (926bbc1)
  • Fix issue where the footer shift up from the bottom if the page is small (71083c7)

@syphax-bouazzouni
Copy link
Collaborator

The new configration of the footer

$FOOTER_LINKS = {
  social: [
    { logo: "social/people.svg", link: "https://github.com/orgs/agroportal/people" },
    { logo: "social/github.svg", link: "https://github.com/agroportal" },
    { logo: "social/twitter.svg", link: "https://twitter.com/lagroportal" },
  ],
  sections: {
    products: {
      ontoportal: "https://ontoportal.org/",
      release_notes: "https://doc.jonquetlab.lirmm.fr/share/e6158eda-c109-4385-852c-51a42de9a412/doc/release-notes-btKjZk5tU2",
      api: "https://data.agroportal.lirmm.fr/",
      sparql: "https://sparql.agroportal.lirmm.fr/test/"
    },
    support: {
      contact_us: "https://agroportal.lirmm.fr/feedback",
      wiki: "https://www.bioontology.org/wiki/",
      documentation: "https://ontoportal.github.io/documentation/"
    },
    agreements: {
      terms: "",
      privacy_policy: "",
      cite_us: "",
      acknowledgments: ""
    },
    about: {
      about_us: "https://github.com/agroportal/project-management",
      projects: "https://d2kab.mystrikingly.com/",
      team: "https://github.com/orgs/agroportal/people"
    }
  }
}

syphax-bouazzouni added a commit that referenced this pull request Dec 5, 2023
… previews in the lookbook (#336)

* Merge pull request #234 from ontoportal-lirmm/feature/update-footer-design

Feature: Update footer design

* Merge pull request #249 from ontoportal-lirmm/feature/update-account-page-submited-onto

Feature: Update account page submitted ontologies

* Merge pull request #236 from ontoportal-lirmm/feature/lookbook

Feature: Add Lookbook to preview components

* Merge pull request #242 from ontoportal-lirmm/feature/lookbook

Feature: Add Lookbook to preview view components - fix the new version release

* Merge pull request #262 from ontoportal-lirmm/feature/add-rounded-button-component-to-lookbook

Feature: Add rounded button to lookbook

* Merge pull request #248 from ontoportal-lirmm/feature/add-notification-message-component

Feature: Add notification message component

* Merge pull request #268 from ontoportal-lirmm/feature/add-submission-fields-components

Feature: Add submission fields components

* Merge pull request #288 from ontoportal-lirmm/feature/add-upload-ontology-components-to-lookbook

Feature: Add form inputs components to lookbook

* Merge pull request #284 from ontoportal-lirmm/feature/update-nested-from-input-component-design

Feature: Update nested form input component design

* Merge pull request #282 from ontoportal-lirmm/feature/extract-search-input-component

Feature: Extract search input component

* Merge pull request #296 from ontoportal-lirmm/feature/re-organize-lookbook

Feature: Re organize lookbook previews

* Merge pull request #305 from ontoportal-lirmm/feature/add-table-component

Feature: Add table component & Migrate the views to use it

* Merge pull request #312 from ontoportal-lirmm/feature/extract-search-input-component

Feature: Extract search input component - follow up

* Merge pull request #313 from ontoportal-lirmm/fix/nested-from-component-empty-state

Fix: Nested form component empty state

* Merge pull request #301 from ontoportal-lirmm/feature/add-switch-input-preview

Feature: Add switch input preview

* Merge pull request #304 from ontoportal-lirmm/feature/add-link-text-components

Feature: Add link text components

* Merge pull request #310 from ontoportal-lirmm/feature/update-select-component

Feature: update select component

* Merge pull request #300 from ontoportal-lirmm/feature/add-modal-link-component

Feature: Add modal component preview and helpers

* Merge pull request #303 from ontoportal-lirmm/feature/add-pill-button

Feature: Add pill button

* Merge pull request #297 from ontoportal-lirmm/feature/add-tabs-component

Feature: Add tabs component

* Merge pull request #306 from ontoportal-lirmm/feature/add-circle-progress-bar-component

Feature: Add circle progress bar component (style, JS, code and preview)

* Merge pull request #247 from ontoportal-lirmm/feature/update-agroportal-primary-color

Feature: Update AgroPortal primary color

* Merge pull request #319 from ontoportal-lirmm/feature/extract-form-input-components

Feature: Extract form input components

* Merge pull request #324 from ontoportal-lirmm/feature/add-summary-page-components

Feature: Extract summary page components

* Merge pull request #314 from ontoportal-lirmm/add-buttons-components-to-lookbook

Feature: Add buttons components to lookbook

* Feature: Add progress pages component (#328)

* add progress pages component

* put again the type argument for button component

* fix progress pages item not center if test is long

* make progress pages container take full width by default

* Fix progress item position (first & last one) to be aligned with the content

* fix progress item checked state to show the icon and the good background

* make the progress page component preview width bigger

---------

Co-authored-by: Bilel Kihal <[email protected]>

* Merge pull request #259 from ontoportal-lirmm/feature/add-other-states-to-card-message-component

Feature: Add warning state to card message component

* Merge pull request #238 from ontoportal-lirmm/feature/update-nav-bar-design

Feature: Update nav bar design

* Merge pull request #331 from ontoportal-lirmm/feature/update-404-error-design

Feature: Update 404 error design

* Merge pull request #263 from ontoportal-lirmm/feature/update-nav-bar-design

Fix: replace nav_bar  css nav-link to top-nav-nav-link to prevent conflicts

---------

Co-authored-by: Bilel Kihal <[email protected]>
syphax-bouazzouni added a commit that referenced this pull request Dec 5, 2023
… previews in the lookbook (#336)

* Merge pull request #234 from ontoportal-lirmm/feature/update-footer-design

Feature: Update footer design

* Merge pull request #249 from ontoportal-lirmm/feature/update-account-page-submited-onto

Feature: Update account page submitted ontologies

* Merge pull request #236 from ontoportal-lirmm/feature/lookbook

Feature: Add Lookbook to preview components

* Merge pull request #242 from ontoportal-lirmm/feature/lookbook

Feature: Add Lookbook to preview view components - fix the new version release

* Merge pull request #262 from ontoportal-lirmm/feature/add-rounded-button-component-to-lookbook

Feature: Add rounded button to lookbook

* Merge pull request #248 from ontoportal-lirmm/feature/add-notification-message-component

Feature: Add notification message component

* Merge pull request #268 from ontoportal-lirmm/feature/add-submission-fields-components

Feature: Add submission fields components

* Merge pull request #288 from ontoportal-lirmm/feature/add-upload-ontology-components-to-lookbook

Feature: Add form inputs components to lookbook

* Merge pull request #284 from ontoportal-lirmm/feature/update-nested-from-input-component-design

Feature: Update nested form input component design

* Merge pull request #282 from ontoportal-lirmm/feature/extract-search-input-component

Feature: Extract search input component

* Merge pull request #296 from ontoportal-lirmm/feature/re-organize-lookbook

Feature: Re organize lookbook previews

* Merge pull request #305 from ontoportal-lirmm/feature/add-table-component

Feature: Add table component & Migrate the views to use it

* Merge pull request #312 from ontoportal-lirmm/feature/extract-search-input-component

Feature: Extract search input component - follow up

* Merge pull request #313 from ontoportal-lirmm/fix/nested-from-component-empty-state

Fix: Nested form component empty state

* Merge pull request #301 from ontoportal-lirmm/feature/add-switch-input-preview

Feature: Add switch input preview

* Merge pull request #304 from ontoportal-lirmm/feature/add-link-text-components

Feature: Add link text components

* Merge pull request #310 from ontoportal-lirmm/feature/update-select-component

Feature: update select component

* Merge pull request #300 from ontoportal-lirmm/feature/add-modal-link-component

Feature: Add modal component preview and helpers

* Merge pull request #303 from ontoportal-lirmm/feature/add-pill-button

Feature: Add pill button

* Merge pull request #297 from ontoportal-lirmm/feature/add-tabs-component

Feature: Add tabs component

* Merge pull request #306 from ontoportal-lirmm/feature/add-circle-progress-bar-component

Feature: Add circle progress bar component (style, JS, code and preview)

* Merge pull request #247 from ontoportal-lirmm/feature/update-agroportal-primary-color

Feature: Update AgroPortal primary color

* Merge pull request #319 from ontoportal-lirmm/feature/extract-form-input-components

Feature: Extract form input components

* Merge pull request #324 from ontoportal-lirmm/feature/add-summary-page-components

Feature: Extract summary page components

* Merge pull request #314 from ontoportal-lirmm/add-buttons-components-to-lookbook

Feature: Add buttons components to lookbook

* Feature: Add progress pages component (#328)

* add progress pages component

* put again the type argument for button component

* fix progress pages item not center if test is long

* make progress pages container take full width by default

* Fix progress item position (first & last one) to be aligned with the content

* fix progress item checked state to show the icon and the good background

* make the progress page component preview width bigger

---------

Co-authored-by: Bilel Kihal <[email protected]>

* Merge pull request #259 from ontoportal-lirmm/feature/add-other-states-to-card-message-component

Feature: Add warning state to card message component

* Merge pull request #238 from ontoportal-lirmm/feature/update-nav-bar-design

Feature: Update nav bar design

* Merge pull request #331 from ontoportal-lirmm/feature/update-404-error-design

Feature: Update 404 error design

* Merge pull request #263 from ontoportal-lirmm/feature/update-nav-bar-design

Fix: replace nav_bar  css nav-link to top-nav-nav-link to prevent conflicts

---------

Co-authored-by: Bilel Kihal <[email protected]>
syphax-bouazzouni pushed a commit that referenced this pull request Feb 29, 2024
Add initial support for ontology change requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor portal footer design
3 participants