Merge to master: Release 2.9.1 - Agents and global bug fixes #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove duplicate from gemfile * add port 3000 for production to use it with ontoportal_docker * add commands to run production correctly
* add rewrite condition in the rewrite rules * refactor and clean code of htaccess and nginx redirection rules
* Fix ontologies custom set feature * enhance custom set feature style * remove duplicated action in home controller account, which is the same as show in users controller * clean application helper ontologies selector code * remove unecessary server calls in account page * Remove JQuery code in accounts page * remove repeated server call in custom ontologies features * fix the login flow test after deleting the repeated action related to `/acount`
* fix clicking on subscribe button while being not logged in * remove non related code to fix subscribe button issues PR * fix subscribe button displays wrong values when using french * replace UnWatch by unwatch * clean subscriptions method code in ontologies controller * Fix the color of the loader component spinning loader * remove duplicated code in subscription button fix * disable cache for subscription button calls * remove invalidate cache for the user calls
) * add response time calculation in check resolvability tool * add other format equivalents to handle most cases of request accept header * move the AVG time to check_resolvability_message instead of appending it * remove the usage of inexistent variable in that block scope * remove comment as the variable name is already clear --------- Co-authored-by: Syphax Bouazzouni <[email protected]>
* add cookies action to show and save cookie state in a session * add link button component helper * add cookie modal view * enhance the style of the cookies banner --------- Co-authored-by: Bilel KIHAL <[email protected]>
…tip (#713) * update summary page categories display to show acronym with tooltip * fix submission flow system tests after changing their display * make show_category return the full domain if not a category * update the show category name to use clickable state if not a category and is a link
* make agents search field component results unlimited to only 4 * make agents cherchable by acronym, affiliations, email and home page * Update the agent search input to display the result in this format Orga name (ACRONYM) – ROR:003vg9w96 and for persons Person Name – ORCID:0000-1524-5487-5487 * chagne display mode value type from string to boolean in search input component * remove agents search logic from UI side and limit it to only name, acronym and identifiers * use the endpoint '/search/agents' for the agents search input component
* Hide affiliations when the agent is an organization in the agents form * Change the name of the function affliations? to is_organization? to make it more clear * fix submission flows test after the fix of the PR #713 * fix agent tests after changing the behavior of displaying affiliations --------- Co-authored-by: Syphax <[email protected]>
…type (#721) * remove the restriction for certain submission fields to create only organization type or person type agents * make orcid or ror default input based on agent type in agent form * fix disappeared signup form icons * fix nested agents creation * fix agent form not filling saved identifier values * create an agent identifier input helper * disable cookie banner in development and test mode * fix agent tests after enforcing ROR for organizations --------- Co-authored-by: Syphax <[email protected]>
* Fix propertyId param auto added to summary page URL * remove added PropertyId param to the URL when opening summary page * Fix auto added propertyId to the summary page URL * Fix auto added instanceid to the summary page URL * Fix auto added propertyId to the summary page URL * add back the constraint of making frames loading lazy while env.development * make by default properties section displays the first property * make by default instances section displays the first instance * change the name of the function instances_tree_first_id by search_first_instance_id * add a clarification comment in search_first_instance_id method * move get_property function to properties controller --------- Co-authored-by: Syphax <[email protected]>
* accept different orcid forms in agents creation/update form * humanize empty values errors in creating and updating agents * accept ror identifier in all forms and handle it in the UI * humanize identifier already used when updating agent * put agent form errors in local lang files * extract generate agents errors function * remove ror/orcid ui validators * enhance invalid agents identifiers url error message
* disable email displaying in agents chips tooltip * display agent acronym for organization in agent chip component when available * hide email in agent chip tooltip only for agents and not for contacts
* add cookies action to show and save cookie state in a session * add link button component helper * add cookie modal view * enhance the style of the cookies banner * update cookie banner text and remove deny button --------- Co-authored-by: Bilel KIHAL <[email protected]>
* fix: identifier for organizations is ror and for persons is orcid * disable multiple identifiers for agents in agents form * remove the restriction for certain submission fields to create only organization type or person type agents * fix agent tests after changing agent identifier to not be a list --------- Co-authored-by: Syphax <[email protected]>
syphax-bouazzouni
force-pushed
the
development
branch
from
a6deaf1 to
d94b7b4
Compare
syphax-bouazzouni
force-pushed
the
development
branch
from
d94b7b4 to
d40389d
Compare
syphax-bouazzouni
changed the title
|
Rebased this branch, reviewed all the changes, and all the tests are green. So I merge. @Bilelkihal you can deploy the API and UI using the CI when you are ready. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Features
URI managment
Agents
Cookie banner
Feature: add search placeholder to data table component #688
Feature: hide analytics features if not enabled #691
Feature: add ontology viewOf the the summary page relation network #716
Feature: remove subject values from the project and usage block in summary page #719
Bug fixes
Backend releases