Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: enable and disable twitter section #880

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

imadbourouche
Copy link
Member

@imadbourouche imadbourouche commented Dec 3, 2024

Context

Adding env variable to enable or disable showing the twitter section in the home page.

Screenshots

  • Twitter enabled

twitter_section_enabled

  • Twitter disabled

Screenshot from 2024-12-10 11-09-45

@imadbourouche imadbourouche added the enhancement New feature or request label Dec 3, 2024
@imadbourouche imadbourouche self-assigned this Dec 3, 2024
@imadbourouche imadbourouche changed the title Feature/enable and disable twitter section Feature: enable and disable twitter section Dec 4, 2024
@imadbourouche
Copy link
Member Author

Note: when twitter is disabled, we can use the "spider/radar chart" instead of just showing the faire score as discussed with @jonquet like this one

159973558-3ef49b10-f363-4172-9565-c3cc8a347881

Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this iteration just let the block as an empty white space. Will think of a better a replacement in the future if requested.

@imadbourouche imadbourouche requested review from syphax-bouazzouni and Bilelkihal and removed request for Bilelkihal December 10, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants