Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: handle default attribute in case it's not proc #71

Merged

Conversation

imadbourouche
Copy link
Member

Context

Solution

The solution consiste on first check the value if it's proc/lambda. If it's the case we proceed to do value.call(self) otherwise we send the value as it is.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (3f8b1f0) to head (1e98cfd).
Report is 23 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development      #71      +/-   ##
===============================================
+ Coverage        86.35%   86.46%   +0.11%     
===============================================
  Files               46       46              
  Lines             3027     3067      +40     
===============================================
+ Hits              2614     2652      +38     
- Misses             413      415       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syphax-bouazzouni syphax-bouazzouni self-requested a review February 5, 2025 13:13
Copy link
Member Author

@imadbourouche imadbourouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test are passing @syphax-bouazzouni

@syphax-bouazzouni syphax-bouazzouni merged commit 5617d26 into development Feb 5, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants