Merge pull request #151 from ncbo/refactor/remove-duplicates-fix-erro…

…r-msg remove duplicates, fix error message
ontoportal-lirmm · May 23, 2024 · 9dbf2d4 · 9dbf2d4
2 parents c53f759 + 05e4bba
commit 9dbf2d4
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/helpers/application_helper.rb b/helpers/application_helper.rb
@@ -396,18 +396,9 @@ def get_ontology_and_submission
         else
           submission = ont.latest_submission(status: [:RDF])
         end
-        if submission.nil?
-          error 404,  "Ontology #{@params["ontology"]} submission not found."
-        end
+        error 404, "Ontology #{@params["ontology"]} submission not found." if submission.nil?
         if !submission.ready?(status: [:RDF])
-          error(404,
-                "Ontology #{@params["ontology"]} submission i"+
-                "#{submission.submissionId} has not been parsed.")
-        end
-        if submission.nil?
-          if submission.nil?
-            error 404, "Ontology #{@params["acronym"]} does not have any submissions"
-          end
+          error 404, "Ontology #{@params["ontology"]} submission #{submission.submissionId} has not been parsed."
         end
 
         save_submission_language(submission)