Fix: remove ontology creation notification because replaced with submission creation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new workflow of creating ontologies. As the form of the ontology and submission is the same, sometimes we can have an ontology valid and created but the submission part is erroneous, so for now we create an ontology on each save and remove it if the submission is not valid. (we can't test the validity of an orphan submission)
This raises an issue which is that we send a notification of ontology creation even if it's removed just after because of its no validity.
This is a temporary fix until we do an iteration on the notification system. where before we had two notifications, one when an ontology is created and one when the submission is parsed. Now only the latter is sent and we removed the ontology creation notification sent to the admins.