Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master: Release 2.4.0 - Multi-backend stores integrations, URI content negotiation and Ontology metadata and data indexation #73

Merged
merged 14 commits into from
May 22, 2024

Conversation

syphax-bouazzouni and others added 7 commits January 30, 2024 13:09
* set up multiple triple store test environment

* optimize api tests
* update ncbo_annotator gem version

* update alegrograph to version 8.1.0
* update docker compose to use standard SOLR not the ontoportal configured

* update term search to use the new Schema API and remove config files

* update properties search to use the new Schema API & remove config files

* update class and properties schema to use the existent dynamic names
…arious output formats(#69)

* remove useless line preventing sending the reset password email (#65)

* [ontoportal-bot] Gemfile.lock update

* Feature: api endpoint returns json-ld  for the element with that URI

* implement GET, POST requests, and GET /parse to submit INRATHES ontology

* Enhance tests using real data submission

* Enhance bin/ontoportal to make it able to run localy with UI

* Small fixes

- change controller name and test controller name
- remove /parse endpoint
- rackup to shotgun in bin/ontoportal

* Fix test dereference resource controller

- in json test, before we test the result we sort the hashes with the function (sort_nested_hash)
- in xml, ntriples and turtle, we split the result and the expected result, sort them and compare them

* update gemfile: add json-ld (3.0.2)

* change derefrencement namespacing and clean code

* Fix dereference resource tests expected resultsto handle parse triples

* fix xml serialization test for AG and Gb by cleaning the xml string

---------

Co-authored-by: OntoPortal Bot <[email protected]>
Co-authored-by: imadbourouche <[email protected]>
* remove useless line preventing sending the reset password email (#65)

* [ontoportal-bot] Gemfile.lock update

* Feature: api endpoint returns json-ld  for the element with that URI

* implement GET, POST requests, and GET /parse to submit INRATHES ontology

* Enhance tests using real data submission

* Enhance bin/ontoportal to make it able to run localy with UI

* Small fixes

- change controller name and test controller name
- remove /parse endpoint
- rackup to shotgun in bin/ontoportal

* Fix test dereference resource controller

- in json test, before we test the result we sort the hashes with the function (sort_nested_hash)
- in xml, ntriples and turtle, we split the result and the expected result, sort them and compare them

* update gemfile: add json-ld (3.0.2)

* change derefrencement namespacing and clean code

* Fix dereference resource tests expected resultsto handle parse triples

* Feature: add content negotiation middleware

* Add headers to tests instead of output_format

* Apply middleware to only /ontologies/:acronym/resolve/:uri

* Add test cases for AllegroGraph and fix xml test

* move the content_negotiation middleware into rack folder and  module

* re-implement again the usage of  the output_format param if no format is given in the request header

* clean the tests for no more necessary checks

* clean and simplify the content negotiation middleware

* add the accepted format in the error response of resolvability endpoint

* refactor the content negotiation middleware code to be more clear

---------

Co-authored-by: Syphax bouazzouni <[email protected]>
Co-authored-by: OntoPortal Bot <[email protected]>
@syphax-bouazzouni syphax-bouazzouni changed the title Merge to master: Release 2.4.0 Merge to master: Release 2.4.0 - Multi-backend stores integrations, URI content negotiation and Ontology metadata and data indexation Apr 3, 2024
* extract slice tests helper to the parent class for reusability

* add a test for the creation of an admin user

* enforce the security of admin user creation

* update slices controller to enforce admin security
* index submission and agents metadata

* add search administration endpoints to init schema and index batch

* add ontology and agent search endpoints

* add agent and ontology search tests

* add admin search in collections

* make the search admin use directly the solr connector

* implement search ontologies content search endpoint

* enforce solr models indexing one by one to prevent batch fails

* add detType tov search ontologies  content search endpoint

* fix content ontology search pagination

* add ontology search content types filter
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 79.07950% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 71.61%. Comparing base (b8436be) to head (0fada75).
Report is 2 commits behind head on master.

Current head 0fada75 differs from pull request most recent head 5c03e7e

Please upload reports for the commit 5c03e7e to get more accurate results.

Files Patch % Lines
controllers/admin_controller.rb 45.45% 24 Missing ⚠️
lib/rack/content_negotiation.rb 69.81% 16 Missing ⚠️
controllers/search_controller.rb 94.00% 6 Missing ⚠️
controllers/dereference_resource_controller.rb 89.28% 3 Missing ⚠️
controllers/slices_controller.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   70.78%   71.61%   +0.82%     
==========================================
  Files          65       67       +2     
  Lines        3420     3646     +226     
==========================================
+ Hits         2421     2611     +190     
- Misses        999     1035      +36     
Flag Coverage Δ
unittests 71.61% <79.07%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

syphax-bouazzouni and others added 4 commits April 24, 2024 02:55
…arch results (#74)

* add ontology accessibility restriction  to ontology metadata search

* add ontology accessibility restriction  to ontology content search

* add search results accessibility security test
* Merge pull request https://github.com/ncbo/ontologies_api/pull/120from ncbo/remove_redis-activesupport

Remove redis activesupport

* use the branch development of sparql client
* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants