Feature: Aggretate federated search results

[Bilelkihal]

Related UI PR: ontoportal-lirmm/bioportal_web_ui#739

Changes

• Implemented federated search, aggregating results in a collection key.
• Passed errors in a separate errors key.
• Added a test to validate this feature.

[Bilelkihal]

Yes, good remark. I’ll do it right now. *Bilel KIHAL*. Research engineer @ INRAE

…

On Fri 4 Oct 2024 at 09:36, Syphax bouazzouni ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/ontologies_api_client/models/class.rb <#18 (comment)> : > raise ArgumentError, "You must provide a search query: Class.search(query: 'melanoma')" if query.nil? || !query.is_a?(String) - HTTP.post("/search", params) + + + search_result = federated_get(params) do |url| + "#{url}/search" + end + merged_collections = {results: [], errors: []} + search_result.each do |result| + if result.collection + merged_collections[:results].concat(result.collection) + elsif result.errors + merged_collections[:errors] << result.errors by the way here you should change results by collection, otherwise you changing the endpoint expected schema. — Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXCOTUIBK3EZA3NUQWQJ5LZZZAPHAVCNFSM6AAAAABNMBVPCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBXGM2DOOBSGQ> . You are receiving this because you were assigned.Message ID: <ontoportal-lirmm/ontologies_api_ruby_client/pull/18/review/2347347824@ github.com>

[Bilelkihal]

✅

[syphax-bouazzouni]

Code approved, require just description before merging.