Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: zombie mapping count #167

Merged
merged 9 commits into from
Nov 10, 2024
Merged

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Nov 2, 2024

Fix ontoportal-lirmm/ontologies_api#106

Changes

  • Add unit test for zombie mapping count (f523fd5)
  • Extract mapping count functions into a separate module (376c261)
  • On submission, archiving and deletion remove the graph (955167b)
  • Remove mapping count if their ontologies do no more exist (70565c2 and c1b5051 )
  • Add unit test to be sure that archived submission data graph are removed (a680ef1)

@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to development November 2, 2024 14:46
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 88.20225% with 21 lines in your changes missing coverage. Please review.

Project coverage is 82.44%. Comparing base (337dce9) to head (a680ef1).
Report is 37 commits behind head on development.

Files with missing lines Patch % Lines
...es_linked_data/concerns/mappings/mapping_counts.rb 87.57% 20 Missing ⚠️
...tologies_linked_data/models/ontology_submission.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #167      +/-   ##
===============================================
+ Coverage        81.31%   82.44%   +1.12%     
===============================================
  Files               89      103      +14     
  Lines             6512     6834     +322     
===============================================
+ Hits              5295     5634     +339     
+ Misses            1217     1200      -17     
Flag Coverage Δ
unittests 82.44% <88.20%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syphax-bouazzouni syphax-bouazzouni merged commit 564b26e into development Nov 10, 2024
26 checks passed
syphax-bouazzouni added a commit that referenced this pull request Nov 10, 2024
* add unit test for filtering class children by a scheme

* implement submission class children function

* add unit test for zombie mapping count

* extract mapping count functions into a separated module

* remove mapping count if there ontologies does no more exist

* on submission archiving and deletion remove the graph

* update delete zombie mapping counts to check also submission deletion

* add unit test to be sure that archived submission data graph are removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mappings endpoints is not cohenrent with the mappings count
1 participant