revert benchmark to what it was initially

Signed-off-by: David Anyatonwu <[email protected]>
onyedikachi-david · Sep 16, 2024 · 3ecb0fb · 3ecb0fb
1 parent f873fba
commit 3ecb0fb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 6 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -81,9 +81,11 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y ffmpeg tesseract-ocr libtesseract-dev libavformat-dev libavfilter-dev libavdevice-dev ffmpeg libasound2-dev libgtk-3-dev libsoup-3.0-dev libjavascriptcoregtk-4.1-dev libwebkit2gtk-4.1-dev
+
       - name: Run STT benchmarks
         run: |
           cargo bench --bench stt_benchmark -- --output-format bencher | tee -a stt_output.txt
+
       - name: Upload STT benchmark artifact
         uses: actions/upload-artifact@v3
         with:
@@ -125,4 +127,21 @@ jobs:
           output-file-path: ./cache/ocr/ocr_output.txt
           github-token: ${{ secrets.GH_PAGES_TOKEN }}
           auto-push: true
-          alert-threshold: "200%"
+          alert-threshold: "200%"
+          comment-on-alert: true
+          fail-on-alert: true
+          alert-comment-cc-users: "@louis030195"
+
+      # todo broken
+      # - name: Analyze STT benchmarks
+      #   uses: benchmark-action/github-action-benchmark@v1
+      #   with:
+      #     name: STT Benchmarks
+      #     tool: "cargo"
+      #     output-file-path: ./cache/stt/stt_output.txt
+      #     github-token: ${{ secrets.GH_PAGES_TOKEN }}
+      #     auto-push: true
+      #     alert-threshold: "200%"
+      #     comment-on-alert: true
+      #     fail-on-alert: true
+      #     alert-comment-cc-users: "@louis030195"
diff --git a/.github/workflows/release-app.yml b/.github/workflows/release-app.yml
@@ -33,19 +33,20 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - platform: "macos-latest"
+          - platform: "macos-latest" # for Arm based macs (M1 and above).
             args: "--target aarch64-apple-darwin --features metal"
             target: aarch64-apple-darwin
-          - platform: "macos-latest"
+          - platform: "macos-latest" # for Intel based macs.
             args: "--target x86_64-apple-darwin --features metal"
             target: x86_64-apple-darwin
-          - platform: "ubuntu-22.04"
+          - platform: "ubuntu-22.04" # Ubuntu x86_64
             args: "--features mkl"
             target: x86_64-unknown-linux-gnu
-          - platform: "windows-latest"
+          - platform: "windows-latest" # Windows x86_64
             args: "--target x86_64-pc-windows-msvc --features mkl"
             target: x86_64-pc-windows-msvc
-            pre-build-args: ""
+            pre-build-args: "" # --openblas
+            # windows arm: https://github.com/ahqsoftwares/tauri-ahq-store/blob/2fbc2103c222662b3c6ee0cd71fcde664824f0ef/.github/workflows/publish.yml#L136
 
     runs-on: ${{ matrix.platform }}
     steps: