Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl -> Tar of remote repo #74

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Conversation

nrakochy
Copy link

@nrakochy nrakochy commented Jul 2, 2018

When running these commands -

lein new onyx-app example -- +docker
cd example && lein do clean, uberjar; docker build -t peerimage .

I am getting an error -
cp: can't stat '/tmp/etc/*': No such file or directory

I think this change (# 72) needs to be tweaked a bit, as Docker does not decompress tar files with ADD when referencing a remote URL (cf. #2369)

So, instead, this PR adds curl and pipes it directly to tar, which will keep the archive file off the image. I also switched from the jdk:full image to jre:slim, which should knock off 80 mb or so.

@manuel-uberti
Copy link

Thanks for this.

@lbradstreet lbradstreet changed the base branch from 0.13.x to master December 13, 2018 05:19
@lbradstreet
Copy link
Member

Thanks to you both for reminding me about this. Merged.

@lbradstreet lbradstreet merged commit c47a625 into onyx-platform:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants