Skip to content

Commit

Permalink
fix(sign): cannot notarize (#6)
Browse files Browse the repository at this point in the history
When notarizing the APP, it's necessary to add `--options=runtime`.

At the same time, the issue of krun not being able to load dylib through
env has been fixed, along with some spelling errors.

Signed-off-by: Kevin Cui <[email protected]>
  • Loading branch information
BlackHole1 authored Oct 25, 2024
1 parent ab39af6 commit 04e808d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion krunkit.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<dict>
<key>com.apple.security.hypervisor</key>
<true/>
<key>com.apple.security.cs.disable-library-validationr</key>
<key>com.apple.security.cs.disable-library-validation</key>
<true/>
<key>com.apple.security.cs.allow-dyld-environment-variables</key>
<true/>
</dict>
</plist>
6 changes: 3 additions & 3 deletions main.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ cd $WORK

# codesign
echo "Signing gvproxy..."
codesign --force --sign $CODESIGN_IDENTITY --timestamp $WORK/out/gvproxy
codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp $WORK/out/gvproxy

echo "Signing krunkit..."
codesign --force --sign $CODESIGN_IDENTITY --timestamp --entitlements krunkit.entitlements $WORK/out/krunkit
codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp --entitlements krunkit.entitlements $WORK/out/krunkit

find $WORK/out -name "*.dylib" -type f -exec sh -c "echo 'Signing {}...'; codesign --force --sign $CODESIGN_IDENTITY --timestamp {}" ';'
find $WORK/out -name "*.dylib" -type f -exec sh -c "echo 'Signing {}...'; codesign --force --sign $CODESIGN_IDENTITY --options=runtime --timestamp {}" ';'

# pack
echo "Packing..."
Expand Down

0 comments on commit 04e808d

Please sign in to comment.