Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(host): Refactor fetchers #995

Merged
merged 3 commits into from
Feb 4, 2025
Merged

chore(host): Refactor fetchers #995

merged 3 commits into from
Feb 4, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Feb 3, 2025

Overview

Refactors the fetchers for the single and interop host modes into a shared type, where hint handling can be customized via the HintHandler trait.

makes progress on #987, but doesn't yet implement support on the client side.

@clabby clabby requested a review from refcell as a code owner February 3, 2025 19:20
@clabby clabby added the A-host Area: host binary label Feb 3, 2025
@clabby clabby requested a review from emhane as a code owner February 3, 2025 19:20
@clabby clabby added the K-chore Kind: chore label Feb 3, 2025
@clabby clabby self-assigned this Feb 3, 2025
@clabby
Copy link
Collaborator Author

clabby commented Feb 3, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.0%. Comparing base (6ca5552) to head (8d7067c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/proof-sdk/preimage/src/key.rs 0.0% 13 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from cl/clean-host to main February 3, 2025 20:38
@clabby clabby force-pushed the cl/refactor-fetcher branch from 03615b9 to b98b760 Compare February 3, 2025 21:44
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like the hint handler abstraction, think it works fairly clean. Can always improve later on

@clabby clabby added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 61ed147 Feb 4, 2025
15 of 16 checks passed
@clabby clabby deleted the cl/refactor-fetcher branch February 4, 2025 16:26
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants