Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docker compose example for AgentQnA deployment on AMD ROCm #1166

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Added docker compose example for AgentQnA deployment on AMD ROCm #1166

merged 2 commits into from
Dec 18, 2024
+341 −0

Conversation

artem-astafev
Copy link
Contributor

Type of change

  • Added docker compose example for AgentQnA deployment on AMD ROCm (TGI service is in use).
  • Added CI tests for Docker compose AgentQnA deploymen example on AMD ROCm systems

Tests

Go to GenAIExamples/AgentQnA/tests and run test_compose_on_rocm.sh bash script (./test_compose_on_rocm.sh).

@joshuayao joshuayao linked an issue Nov 21, 2024 that may be closed by this pull request
[Feature] Examples on AMD ROCm for OPEA v1.2 #1178
Closed
5 tasks
@joshuayao joshuayao mentioned this pull request Nov 21, 2024
Closed
5 tasks
@dcmiddle
Copy link
Contributor

dcmiddle commented Dec 6, 2024

please squash your fixup commits

@artem-astafev
Copy link
Contributor Author

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

@dcmiddle
Copy link
Contributor

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

Yes please.
The goal is to arrive at a commit message that explains why a change was made. When the commit history is littered with fixup comments it makes it harder for people to understand the code using tools like git blame.

@artem-astafev artem-astafev force-pushed the feature/add-compose-AgentQnA-example-for-amd-rocm branch 4 times, most recently from 6d20e47 to 26a329f Compare December 16, 2024 09:27
@artem-astafev artem-astafev force-pushed the feature/add-compose-AgentQnA-example-for-amd-rocm branch from 030eb17 to 4b1a924 Compare December 16, 2024 09:37
@artem-astafev
Copy link
Contributor Author

@dcmiddle

please squash your fixup commits

Is it necessary? If I understand write all commits will be squashed after merge.

Yes please. The goal is to arrive at a commit message that explains why a change was made. When the commit history is littered with fixup comments it makes it harder for people to understand the code using tools like git blame.

@dcmiddle Done, I've squash all changes into one commit.

dcmiddle
dcmiddle approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@dcmiddle dcmiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. thanks for the extra cleanup.

@chensuyue chensuyue merged commit df7c192 into opea-project:main Dec 18, 2024
13 checks passed
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Dec 20, 2024
@artem-astafev
Added docker compose example for AgentQnA deployment on AMD ROCm (ope…
379ff0b 
…a-project#1166)

Signed-off-by: artem-astafev <[email protected]>
Signed-off-by: Chingis Yundunov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@chensuyue chensuyue chensuyue approved these changes

@dcmiddle dcmiddle dcmiddle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Examples on AMD ROCm for OPEA v1.2
4 participants
@artem-astafev @dcmiddle @chensuyue @lvliang-intel