-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to model performance by reducing allocations #871
Open
ConnectedSystems
wants to merge
11
commits into
main
Choose a base branch
from
centrality-memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−127
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7d6d4c6
Custom weighted sum function
ConnectedSystems 8f406bc
Tweaks for performance
ConnectedSystems c183ca2
Remove unused implementation
ConnectedSystems a14a3c3
More performance tweaks
ConnectedSystems d391d33
Remove unused function
ConnectedSystems 79b2e4a
Avoid reallocation of habitable location indices
ConnectedSystems 1eb5fbc
Revert change
ConnectedSystems a66ef9d
Appease formatter
ConnectedSystems 1a52814
Switch to `@view()` style for readability
ConnectedSystems 100b7b8
Make broadcasted loops explicit to avoid intermediate allocations
ConnectedSystems eca5c6a
Appease formatter again
ConnectedSystems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any advantage of using
view
instead of the macro@view
here? (I'm asking because the macro seems easier to read to me)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm not sure which is better between
view()
and@view()
(from what I understand the difference should be minimal?) but they both beat@views
, at least when slicing a single matrix (size: 79x3806)view()
@view()
@views
https://www.juliabloggers.com/the-view-and-views-macros-are-you-sure-you-know-how-they-work/
https://discourse.julialang.org/t/difference-between-view-and-view/40798