Adds features to example functionality
#603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 20, 2024 15:51
obj:
anyOf:
enum:
- DSL
- PON
type: string
mbuhot
reviewed
May 12, 2024
| @@ -402,6 +402,10 @@ defmodule OpenApiSpex.Schema do | |||
| def example(%Schema{type: :string, format: :"date-time"}), do: "2020-04-20T16:20:00Z" | |||
| def example(%Schema{type: :string, format: :uuid}), do: "02ef9c5f-29e6-48fc-9ec3-7ed57ed351f6" | |||
|
|
|||
| def example(%Schema{type: :string, pattern: regexp}) when is_binary(regexp), do: | |||
| Randex.stream(Regex.compile!(regexp)) | |||
There was a problem hiding this comment.
If randex is an optional dependency, then this should have some runtime check for the Randex module being loaded?
zorbash
reviewed
May 21, 2024
| @@ -402,6 +402,10 @@ defmodule OpenApiSpex.Schema do | |||
| def example(%Schema{type: :string, format: :"date-time"}), do: "2020-04-20T16:20:00Z" | |||
| def example(%Schema{type: :string, format: :uuid}), do: "02ef9c5f-29e6-48fc-9ec3-7ed57ed351f6" | |||
|
|
|||
| def example(%Schema{type: :string, pattern: regexp}) when is_binary(regexp), do: | |||
| Randex.stream(Regex.compile!(regexp)) | |||
There was a problem hiding this comment.
For this change to generate examples matching the schema, it must also take into account the minLength and maxLength properties. Does Randex support such parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows generation of context based on regexp
Allows for non object types anyOf's and oneOf's like