Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Terrain instrument #43

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

RustoMCSpit
Copy link
Contributor

No audio, waiting for consensus

Everything works fine

Also, surely we can get the system to check the sha256 / size and add that to the metadata automatically, right?

@kmturley
Copy link
Member

kmturley commented Dec 6, 2024

This one looks great. Just needs:

  • Terrain.jpg to be terrain.jpg
  • audio preview to be added

Then I think it's good to merge!

@RustoMCSpit
Copy link
Contributor Author

This one looks great. Just needs:

  • Terrain.jpg to be terrain.jpg
  • audio preview to be added

Then I think it's good to merge!

for audio
#44

@RustoMCSpit
Copy link
Contributor Author

This one looks great. Just needs:

* `Terrain.jpg` to be `terrain.jpg`

* audio preview to be added

Then I think it's good to merge!

done but please review #44 asap before i contribute more plugins

@kmturley kmturley merged commit 23c9615 into open-audio-stack:main Dec 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants