Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed absolute path to ../data #19

Merged
merged 2 commits into from
Jan 29, 2014
Merged

Conversation

bsuman79
Copy link
Contributor

lat/long included in cso_events* file (50% of the original entries
contains the coord info)
nocoord.csv contain the list of location that do not contain the
lat/long info

lat/long included in cso_events* file (50% of the original entries
contains the coord info)
nocoord.csv contain the list of location that do not contain the
lat/long info
def cso():
directory='/Users/thoughtworker/chicago-river-sewage/data/'
cso_file='cso_events_timestamped.csv'
def cso(directory='/Users/thoughtworker/chicago-river-sewage/data/', file='cso_events_timestamped.csv', file1='ssmma_mwrd_merge_cleanedup.csv'):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Machine-specific paths make it difficult for others to use. Just data/ would work here instead, no?

@fgregg
Copy link
Member

fgregg commented Jan 28, 2014

@derekeder how does this lat long merging compare with the work you recently did?

@derekeder
Copy link
Member

@bsuman79 will you be at the hack night tonight? It would be useful to go over this PR in person

@bsuman79
Copy link
Contributor Author

is the hack night in chicago?

On Tue, Jan 28, 2014 at 3:20 PM, Derek Eder [email protected]:

@bsuman79 https://github.com/bsuman79 will you be at the hack night
tonight? It would be useful to go over this PR in person

Reply to this email directly or view it on GitHubhttps://github.com//pull/19#issuecomment-33539347
.

@derekeder
Copy link
Member

It is: http://opengovhacknight.org/

If you're not in town, maybe we could do a Skype/Google Hangout?

@bsuman79
Copy link
Contributor Author

I live in sf. I would be happy to join. Can give me a skype contact i can
call into? I am in road now, but probably can call in another 30 min.
Suman
On Jan 28, 2014 3:36 PM, "Derek Eder" [email protected] wrote:

It is: http://opengovhacknight.org/

If you're not in town, maybe we could do a Skype/Google Hangout?

Reply to this email directly or view it on GitHubhttps://github.com//pull/19#issuecomment-33540581
.

@derekeder
Copy link
Member

looks good! merging.

derekeder added a commit that referenced this pull request Jan 29, 2014
changed absolute path to ../data
@derekeder derekeder merged commit 13d3451 into open-city:master Jan 29, 2014
@derekeder
Copy link
Member

relates to #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants