Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon certificate tracking and more addon status condition types #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yue9944882
Copy link
Member

  1. syncing a few existing condition types from the addon-framework, including RegistrationApplied and ManifestApplied
  2. extending new fields in the addon status to track the validtiy of the certificate

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yue9944882
To complete the pull request process, please assign qiujian16 after the PR has been reviewed.
You can assign the PR to them by writing /assign @qiujian16 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yue9944882 yue9944882 changed the title More addon status condition types Addon certificate tracking and more addon status condition types Feb 16, 2022
@yue9944882 yue9944882 force-pushed the api/addon-status-conditions-more branch from 86c6b43 to b797065 Compare February 16, 2022 09:54
@@ -58,6 +58,18 @@ type RegistrationConfig struct {
//
// +optional
Subject Subject `json:"subject,omitempty"`

// certificateStatus actively tracks the status of the certificate used by the addon.
CertificateStatus *RegistrationConfigCertificateStatus `json:"certificateStatus,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field is only used for configuration of registration. I do not think we want to expose this field to addon when setting the configuration. Maybe we should move this out with the name of RegistrationStatuses?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're moving this out, we will need an identifier field for each certificate status struct to correlate the status and registration config. i cant find such an identifier to use, otherwise we will need to duplicate the whole config. wdyt?

@yue9944882 yue9944882 force-pushed the api/addon-status-conditions-more branch 2 times, most recently from 2ccc1cc to 6c045d4 Compare February 17, 2022 09:43
@yue9944882 yue9944882 force-pushed the api/addon-status-conditions-more branch from 6c045d4 to 6fd8353 Compare February 17, 2022 10:01
@yue9944882
Copy link
Member Author

/hold

backoff api-changes until the next release

@openshift-merge-robot
Copy link
Contributor

@yue9944882: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants