Feat: clusteradm get klusterlet-info #143

ycyaoxdu · 2022-03-07T09:17:55Z

Signed-off-by: ycyaoxdu [email protected]

for issue: #133

this feature is a modification of #128

ycyaoxdu · 2022-03-07T09:18:51Z

@qiujian16 please help to review

ycyaoxdu · 2022-03-07T09:56:03Z

╰─$ clusteradm get klusterlet-info --context kind-cluster1                                                                                                                                                    Registration Operator:
  Controller:   (3/3) <none>
  CustomResourceDefinition:
    (installed) klusterlets.operator.open-cluster-management.io
Components:
  Registration:
    Agent:      (1/1) quay.io/open-cluster-management/registration:v0.6.0
  Work:
    Webhook:    (1/1) quay.io/open-cluster-management/work:v0.6.0
  CustomResourceDefinition:
    (installed) appliedmanifestworks.work.open-cluster-management.io [*v1]
    (installed) clusterclaims.cluster.open-cluster-management.io [*v1alpha1]

pkg/cmd/get/klusterletinfo/exec.go

qiujian16 · 2022-03-08T01:35:36Z

pkg/cmd/get/klusterletinfo/exec.go

+)
+
+func (o *Options) run() error {
+	// printing registration-operator


I think we should also consider showing the klusterlet API info here. There is some very helpful info like whether the klusterlet secret is correctly configured.

Will we print the whole API info with the tree-style?

Or we just choose some to show? such as Spec.DeployOption, Status.Conditions?

I would think conditions at first. Actually since it has relatedObject and generations in the status. It probably should read resource from there first and then get the certain resources.

add common utility PrintComponentsCRD for cluster-manager/klusterlet to print crd Signed-off-by: ycyaoxdu <[email protected]>

ycyaoxdu · 2022-03-09T00:11:43Z

For now, the output looks like this:

╰─$ clusteradm get klusterlet-info --context kind-cluster1                                             
Klusterlet Conditions:
  Type:                 HubConnectionDegraded
  Status:               False
  LastTransitionTime:   2022-03-09 08:03:41 +0800 CST
  Reason:               HubConnectionFunctional
  Message:              Hub connection is functioning correctly

  Type:                 Applied
  Status:               True
  LastTransitionTime:   2022-03-07 17:53:17 +0800 CST
  Reason:               KlusterletApplied
  Message:              Klusterlet Component Applied

  Type:                 Available
  Status:               True
  LastTransitionTime:   2022-03-07 17:54:51 +0800 CST
  Reason:               klusterletAvailable
  Message:              deployments are ready: klusterlet-registration-agent,klusterlet-work-agent

  Type:                 RegistrationDesiredDegraded
  Status:               False
  LastTransitionTime:   2022-03-07 17:53:43 +0800 CST
  Reason:               DeploymentsFunctional
  Message:              deployments replicas are desired: 824649212184

  Type:                 WorkDesiredDegraded
  Status:               False
  LastTransitionTime:   2022-03-07 17:54:51 +0800 CST
  Reason:               DeploymentsFunctional
  Message:              deployments replicas are desired: 824649253144

Registration Operator:
  Controller:   (3/3) <none>
  CustomResourceDefinition:
    (installed) klusterlets.operator.open-cluster-management.io
Components:
  Registration:
    Agent:      (1/1) quay.io/open-cluster-management/registration:v0.6.0
  Work:
    Agent:      (1/1) quay.io/open-cluster-management/work:v0.6.0
  CustomResourceDefinition:
    (installed) appliedmanifestworks.work.open-cluster-management.io [*v1]
    (installed) clusterclaims.cluster.open-cluster-management.io [*v1alpha1]

ycyaoxdu · 2022-03-09T01:13:55Z

For now, the output looks like this:

╰─$ clusteradm get klusterlet-info --context kind-cluster1                                             
Klusterlet Conditions:
  Type:                 HubConnectionDegraded
  Status:               False
  LastTransitionTime:   2022-03-09 08:03:41 +0800 CST
  Reason:               HubConnectionFunctional
  Message:              Hub connection is functioning correctly

  Type:                 Applied
  Status:               True
  LastTransitionTime:   2022-03-07 17:53:17 +0800 CST
  Reason:               KlusterletApplied
  Message:              Klusterlet Component Applied

  Type:                 Available
  Status:               True
  LastTransitionTime:   2022-03-07 17:54:51 +0800 CST
  Reason:               klusterletAvailable
  Message:              deployments are ready: klusterlet-registration-agent,klusterlet-work-agent

  Type:                 RegistrationDesiredDegraded
  Status:               False
  LastTransitionTime:   2022-03-07 17:53:43 +0800 CST
  Reason:               DeploymentsFunctional
  Message:              deployments replicas are desired: 824649212184

  Type:                 WorkDesiredDegraded
  Status:               False
  LastTransitionTime:   2022-03-07 17:54:51 +0800 CST
  Reason:               DeploymentsFunctional
  Message:              deployments replicas are desired: 824649253144

Registration Operator:
  Controller:   (3/3) <none>
  CustomResourceDefinition:
    (installed) klusterlets.operator.open-cluster-management.io
Components:
  Registration:
    Agent:      (1/1) quay.io/open-cluster-management/registration:v0.6.0
  Work:
    Agent:      (1/1) quay.io/open-cluster-management/work:v0.6.0
  CustomResourceDefinition:
    (installed) appliedmanifestworks.work.open-cluster-management.io [*v1]
    (installed) clusterclaims.cluster.open-cluster-management.io [*v1alpha1]

seems like other info are shown here except below 5: role rolebinding clusterrole clusterrolebinding serviceaccont.
will we show all these in output ?
@qiujian16

…mponentsCRD, printer.PrintComponentsDeploy to replace printComponentsDelpoyment. Signed-off-by: ycyaoxdu <[email protected]>

ycyaoxdu · 2022-03-14T03:01:28Z

add common utilities: printer.PrintComponentsDeploy and printer.PrintComponentsCRD.
and also modified command clusteradm get hub-info

qiujian16

/approve
/lgtm

qiujian16 · 2022-03-10T01:39:24Z

pkg/cmd/get/klusterletinfo/exec.go

+}
+
+func (o *Options) printComponents() error {
+	klet, err := o.operatorClient.OperatorV1().


why get this again?

openshift-ci · 2022-03-15T01:38:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from itdove and qiujian16 March 7, 2022 09:18

qiujian16 reviewed Mar 8, 2022

View reviewed changes

add get klusterlet-info command

b163921

add common utility PrintComponentsCRD for cluster-manager/klusterlet to print crd Signed-off-by: ycyaoxdu <[email protected]>

ycyaoxdu force-pushed the feat/get-klusterlet-info branch from 706908e to 0aa7e82 Compare March 9, 2022 00:10

openshift-ci bot added do-not-merge/hold and removed do-not-merge/hold labels Mar 9, 2022

ycyaoxdu changed the title ~~Feat: clusteradm get klusterlet-info~~ WIP Feat: clusteradm get klusterlet-info Mar 9, 2022

openshift-ci bot added the do-not-merge/work-in-progress label Mar 9, 2022

ycyaoxdu changed the title ~~WIP Feat: clusteradm get klusterlet-info~~ Feat: clusteradm get klusterlet-info Mar 9, 2022

openshift-ci bot removed the do-not-merge/work-in-progress label Mar 9, 2022

ycyaoxdu force-pushed the feat/get-klusterlet-info branch from 0aa7e82 to eab7e7d Compare March 14, 2022 02:56

fix: use common utility printer.PrintComponentsCRD to replace printCo…

02f2cf4

…mponentsCRD, printer.PrintComponentsDeploy to replace printComponentsDelpoyment. Signed-off-by: ycyaoxdu <[email protected]>

ycyaoxdu force-pushed the feat/get-klusterlet-info branch from eab7e7d to 02f2cf4 Compare March 14, 2022 02:58

qiujian16 reviewed Mar 15, 2022

View reviewed changes

openshift-ci bot assigned qiujian16 Mar 15, 2022

openshift-ci bot added the lgtm label Mar 15, 2022

openshift-ci bot added the approved label Mar 15, 2022

openshift-merge-robot merged commit 1a74a74 into open-cluster-management-io:main Mar 15, 2022

ycyaoxdu deleted the feat/get-klusterlet-info branch March 15, 2022 07:51

ycyaoxdu restored the feat/get-klusterlet-info branch March 15, 2022 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: clusteradm get klusterlet-info #143

Feat: clusteradm get klusterlet-info #143

ycyaoxdu commented Mar 7, 2022

ycyaoxdu commented Mar 7, 2022

ycyaoxdu commented Mar 7, 2022

qiujian16 Mar 8, 2022

ycyaoxdu Mar 8, 2022

ycyaoxdu Mar 8, 2022

qiujian16 Mar 8, 2022

ycyaoxdu commented Mar 9, 2022

ycyaoxdu commented Mar 9, 2022 •

edited

Loading

ycyaoxdu commented Mar 14, 2022

qiujian16 left a comment

qiujian16 Mar 10, 2022

openshift-ci bot commented Mar 15, 2022

Feat: clusteradm get klusterlet-info #143

Feat: clusteradm get klusterlet-info #143

Conversation

ycyaoxdu commented Mar 7, 2022

ycyaoxdu commented Mar 7, 2022

ycyaoxdu commented Mar 7, 2022

qiujian16 Mar 8, 2022

Choose a reason for hiding this comment

ycyaoxdu Mar 8, 2022

Choose a reason for hiding this comment

ycyaoxdu Mar 8, 2022

Choose a reason for hiding this comment

qiujian16 Mar 8, 2022

Choose a reason for hiding this comment

ycyaoxdu commented Mar 9, 2022

ycyaoxdu commented Mar 9, 2022 • edited Loading

ycyaoxdu commented Mar 14, 2022

qiujian16 left a comment

Choose a reason for hiding this comment

qiujian16 Mar 10, 2022

Choose a reason for hiding this comment

openshift-ci bot commented Mar 15, 2022

ycyaoxdu commented Mar 9, 2022 •

edited

Loading