Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command clusterset unbind #148

Conversation

ycyaoxdu
Copy link
Member

@ycyaoxdu ycyaoxdu commented Mar 9, 2022

help unbind clusterset from namespace

Opened for #133

Signed-off-by: ycyaoxdu [email protected]

@openshift-ci openshift-ci bot requested review from itdove and qiujian16 March 9, 2022 07:50
@ycyaoxdu
Copy link
Member Author

ycyaoxdu commented Mar 9, 2022

@qiujian16 please help to review, thanks.

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, ycyaoxdu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8048b16 into open-cluster-management-io:main Mar 9, 2022
@ycyaoxdu ycyaoxdu deleted the feat/clusterset-unbind branch March 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants