✨ Implement ignoreFields in server side apply #726
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiujian16
force-pushed
the
mw-udpate-strategy
branch
from
0575d30 to
eae7b9f
Compare
|
/hold |
qiujian16
force-pushed
the
mw-udpate-strategy
branch
2 times, most recently
from
aac9e2e to
ad9643b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
+ Coverage 63.33% 63.43% +0.09%
==========================================
Files 187 187
Lines 17921 17985 +64
==========================================
+ Hits 11351 11409 +58
- Misses 5635 5637 +2
- Partials 935 939 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qiujian16
force-pushed
the
mw-udpate-strategy
branch
from
ad9643b to
52a5ab8
Compare
|
LGTM |
qiujian16
force-pushed
the
mw-udpate-strategy
branch
from
52a5ab8 to
5ce6e8a
Compare
| } | ||
| } | ||
|
|
||
| func TestServerSideApplyWithIgnoreFields(t *testing.T) { |
There was a problem hiding this comment.
Does it make sense if ignorefields is .metadata.xxx? For example, what if ignorefields is .metadata.annotations and type is IgnoreOnSpokePresent, will the existing annotations be kept on the spoke or be override by object-hash?
There was a problem hiding this comment.
it will be kept. We compute the hash for the whole object including metadata.
|
LGTM |
Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
mw-udpate-strategy
branch
from
5ce6e8a to
99c10be
Compare
|
/unhold |
|
/lgtm |
openshift-merge-bot
bot
merged commit 0897da6
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #690