-
Notifications
You must be signed in to change notification settings - Fork 14
chore: add more log output to the e2e tests #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Skarlso
wants to merge
3
commits into
open-component-model:main
Choose a base branch
from
Skarlso:fix-e2e-test-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gergely Brautigam <[email protected]>
Ah, invalid number of pods. I thought I could get away with this, but I can't. :D I will have to update the log dumper. |
Should be working now. Just need to release ocm-e2e-framework first: open-component-model/ocm-e2e-framework#170 |
|
Signed-off-by: Gergely Brautigam <[email protected]>
jakobmoellerdev
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
In an effort to better debug the e2e test failures, let's dump the flux controller logs as well after each test. The teardown should always run hopefully because we never
FailNow()
in the e2e framework.If this isn't working on a failure, I'll have to decise an envtest.AfterEachTest version of the dump.
Which issue(s) this PR fixes