Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: replace docker with oras (#904)" #1005

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Oct 22, 2024

This reverts commit 3cfa228.

What this PR does / why we need it

Which issue(s) this PR fixes

@Skarlso Skarlso requested a review from a team as a code owner October 22, 2024 14:48
@github-actions github-actions bot added the size/l Size of pull request is large (see gardener-robot robot/bots/size.py) label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 5
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
HIGH RISK LICENSES 10
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@Skarlso
Copy link
Contributor Author

Skarlso commented Oct 22, 2024

@jakobmoellerdev If you don't object I don't want to revert the lint and the makefile changes. Can we keep that as they are in main?

@jakobmoellerdev
Copy link
Contributor

I think you would need to add no lints to make sure you dont break any future PRs
Other than that, Im fine

@Skarlso
Copy link
Contributor Author

Skarlso commented Oct 22, 2024

The linter is failing anyways... :D So I'll revert the docker things, but keep the linter modifications and the makefile changes. 👍

@hilmarf hilmarf added this to the 2024-Q4 milestone Oct 22, 2024
@Skarlso Skarlso added the area/ipcei IPCEI-CIS label Oct 22, 2024
api/tech/docker/resolver.go Dismissed Show dismissed Hide dismissed
@frewilhelm
Copy link
Contributor

#975 should be reverted as well, right?

@Skarlso
Copy link
Contributor Author

Skarlso commented Oct 22, 2024

#975 should be reverted as well, right?

Yes, thanks.

@Skarlso Skarlso enabled auto-merge (squash) October 24, 2024 10:18
@Skarlso Skarlso merged commit c76a2ed into main Oct 24, 2024
19 checks passed
@Skarlso Skarlso deleted the revert-oras-change branch October 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI-CIS size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
Status: 🍺 Done
Development

Successfully merging this pull request may close these issues.

5 participants